Skip to content

Fix generation of facter references #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jay7x merged 2 commits into from
Apr 5, 2026
Merged

Fix generation of facter references #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6445a8e
Fix generation of facter references
tuxmea Apr 5, 2026
262bc28
add missing @ sign
tuxmea Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,5 @@ link_report.txt
.yardoc
puppet-docs-build.log
source/.jekyll-cache/
.ruby-version
.ruby-version
Gemfile.lock
1 change: 1 addition & 0 deletions lib/puppet_references.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ def self.build_facter_references(commit)
version4 = Gem::Version.create('4.0.0')
repo = PuppetReferences::Repo.new('facter', FACTER_DIR)
real_commit = repo.checkout(commit)
repo.update_bundle
if !semantic?(commit) || (semantic?(commit) && Gem::Version.create(commit) >= version4)
references << PuppetReferences::Facter::FacterCli
elsif semantic?(commit) && Gem::Version.create(commit) < version4
Expand Down
6 changes: 4 additions & 2 deletions lib/puppet_references/repo.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ def update_bundle
puts "In #{@name} dir: Running bundle update."
PuppetReferences::Util.run_dirty_command('bundle update')
else
puts "In #{@name} dir: Running bundle install --path .bundle/stuff"
PuppetReferences::Util.run_dirty_command('bundle install --path .bundle/stuff')
puts "In #{@name} dir: Running bundle config set --local path '.bundle/stuff'"
PuppetReferences::Util.run_dirty_command("bundle config set --local path '.bundle/stuff'")
puts "In #{@name} dir: Running bundle install"
PuppetReferences::Util.run_dirty_command('bundle install')
end
end
end
Expand Down
Loading