Skip to content

Support podman in tasks/build.rake#227

Open
gregorynisbet-google wants to merge 2 commits intoOpenVoxProject:mainfrom
gregorynisbet-google:2026-03-23-podman-build
Open

Support podman in tasks/build.rake#227
gregorynisbet-google wants to merge 2 commits intoOpenVoxProject:mainfrom
gregorynisbet-google:2026-03-23-podman-build

Conversation

@gregorynisbet-google
Copy link
Copy Markdown

Support podman in addition to docker in tasks/build.rake via the DOCKER environment variable.

Pull Request (PR) description

I did the simplest thing I could think of to make DOCKER=podman rake vox:build succeed.

There are a few differences between --format json for Docker and podman, but I still think
that that's the most robust way to get the commands to emit structured output.

I'm curious whether folks think this is worth doing at all, and whether an environment variable
is the best way of achieving this (and also whether shell substitution is better than doing the
conditional at the ruby level)

This Pull Request (PR) fixes the following issues

n/a

@Sharpie
Copy link
Copy Markdown
Contributor

Sharpie commented Apr 5, 2026

I opened #228 before I noticed this PR. The approach there is even simpler, but requires the use of the podman-docker shim package to re-direct the docker CLI to podman.

Building other OpenVox components, such as openvox-agent and openbolt, under Podman requires the use of podman-docker unless some enhancement is done to Vanagon.

@gregorynisbet-google
Copy link
Copy Markdown
Author

No worries. Any interest in me reworking this to remove the dependency on the shim?

@Sharpie
Copy link
Copy Markdown
Contributor

Sharpie commented Apr 6, 2026

Using environment variables to pick a CLI implementation seems reasonable to me. Perhaps DOCKER_BIN or DOCKER_CLI instead of DOCKER as the shorter variable is sometimes used to flag whether or not a process is running in a containerized environment.

@gregorynisbet-google gregorynisbet-google force-pushed the 2026-03-23-podman-build branch 3 times, most recently from 6a79a0b to cba84c5 Compare April 9, 2026 00:23
@Sharpie Sharpie self-assigned this Apr 9, 2026
Support podman in addition to docker in tasks/build.rake
via the DOCKER environment variable.

Signed-off-by: Greg NISBET <gregorynisbet@google.com>
Copy link
Copy Markdown
Contributor

@Sharpie Sharpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Thanks for the contribution!

@Sharpie Sharpie enabled auto-merge April 11, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants