add runtime deprecation warnings to Puppet::Util ENV wrappers#417
Draft
silug wants to merge 1 commit intoOpenVoxProject:mainfrom
Draft
add runtime deprecation warnings to Puppet::Util ENV wrappers#417silug wants to merge 1 commit intoOpenVoxProject:mainfrom
silug wants to merge 1 commit intoOpenVoxProject:mainfrom
Conversation
The five ENV wrapper methods (get_env, get_environment, clear_environment, set_env, merge_environment) had @deprecated doc comments but no runtime warnings. Add Puppet.deprecation_warning calls to each so callers are notified at runtime when these methods are invoked. Also fix a NameError bug in merge_environment where the parameter env_hash was referenced as hash in the method body. Adds specs asserting each method emits a deprecation warning. See: OpenVoxProject#342 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
The five ENV wrapper methods (get_env, get_environment, clear_environment, set_env, merge_environment) had @deprecated doc comments but no runtime warnings. Add Puppet.deprecation_warning calls to each so callers are notified at runtime when these methods are invoked.
Also fix a NameError bug in merge_environment where the parameter env_hash was referenced as hash in the method body.
Adds specs asserting each method emits a deprecation warning.
See: #342
Checklist
I have:
Signed-off-byannotation to each of my commits