Make source_permissions functional on Windows#420
Draft
silug wants to merge 1 commit intoOpenVoxProject:mainfrom
Draft
Make source_permissions functional on Windows#420silug wants to merge 1 commit intoOpenVoxProject:mainfrom
silug wants to merge 1 commit intoOpenVoxProject:mainfrom
Conversation
Restore the Windows Security API calls in WindowsStat so that source_permissions => use and use_when_creating actually read owner, group, and mode from the source file via Puppet::Util::Windows::Security. Falls back to safe defaults on invalid DACL errors (e.g. non-NTFS volumes) and a known VirtualBox ERROR_INVALID_FUNCTION edge case. The raise in WindowsStat#initialize that blocked non-:ignore values on Windows is removed. Update specs to reflect the new behavior. Related: OpenVoxProject#340 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Restore the Windows Security API calls in WindowsStat so that source_permissions => use and use_when_creating actually read owner, group, and mode from the source file via Puppet::Util::Windows::Security. Falls back to safe defaults on invalid DACL errors (e.g. non-NTFS volumes) and a known VirtualBox ERROR_INVALID_FUNCTION edge case.
The raise in WindowsStat#initialize that blocked non-:ignore values on Windows is removed. Update specs to reflect the new behavior.
Related: #340
Checklist
I have:
Signed-off-byannotation to each of my commits