Skip to content

Fix CA/CRL refresh retriggering every run on 304 #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
houssemexo26 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CA/CRL refresh retriggering every run on 304 #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/puppet/ssl/state_machine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ def refresh_ca(ssl_ctx, last_update)
rescue Puppet::HTTP::ResponseError => e
if e.response.code == 304
Puppet.info(_("CA certificate is unmodified, using existing CA certificate"))
@cert_provider.ca_last_update = Time.now
else
Puppet.info(_("Failed to refresh CA certificate, using existing CA certificate: %{message}") % { message: e.message })
end
Expand Down Expand Up @@ -219,6 +220,7 @@ def refresh_crl(ssl_ctx, last_update)
rescue Puppet::HTTP::ResponseError => e
if e.response.code == 304
Puppet.info(_("CRL is unmodified, using existing CRL"))
@cert_provider.crl_last_update = Time.now
else
Puppet.info(_("Failed to refresh CRL, using existing CRL: %{message}") % { message: e.message })
end
Expand Down