Fix handling of Puppet::Pops serialization issues#502
Open
seanmil wants to merge 1 commit into
Open
Conversation
When a serialization issue is encountered the 'stacktrace' method needs to be called against Puppet::Pops::PuppetStack as there is no 'stacktrace' in scope here. Signed-off-by: Sean Millichamp <sean@bruenor.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
In
Puppet::Pops::Serialization::ToDataConvertera number of different issues can occur during serialization. If an issue is generated and the PuppetStack is not at the top of stack it attempts to include file/line position information but the method call tostacktraceisn't in scope at the call, causing a fatal error. CallingPuppet::Pops::PuppetStack.stacktraceobtains the desired stacktrace for position information.Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent