Skip to content

Fix handling of Puppet::Pops serialization issues#502

Open
seanmil wants to merge 1 commit into
OpenVoxProject:mainfrom
seanmil:fix_serialization_stacktrace
Open

Fix handling of Puppet::Pops serialization issues#502
seanmil wants to merge 1 commit into
OpenVoxProject:mainfrom
seanmil:fix_serialization_stacktrace

Conversation

@seanmil

@seanmil seanmil commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Short description

In Puppet::Pops::Serialization::ToDataConverter a number of different issues can occur during serialization. If an issue is generated and the PuppetStack is not at the top of stack it attempts to include file/line position information but the method call to stacktrace isn't in scope at the call, causing a fatal error. Calling Puppet::Pops::PuppetStack.stacktrace obtains the desired stacktrace for position information.

Checklist

I have:

When a serialization issue is encountered the 'stacktrace'
method needs to be called against Puppet::Pops::PuppetStack as
there is no 'stacktrace' in scope here.

Signed-off-by: Sean Millichamp <sean@bruenor.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant