Skip to content

Add Ruby 3.4 support#10

Closed
bastelfreak wants to merge 3 commits into
OpenVoxProject:mainfrom
bastelfreak:ruby34
Closed

Add Ruby 3.4 support#10
bastelfreak wants to merge 3 commits into
OpenVoxProject:mainfrom
bastelfreak:ruby34

Conversation

@bastelfreak
Copy link
Copy Markdown
Contributor

also contains #9

@bastelfreak bastelfreak requested a review from smortex July 9, 2025 20:19
@bastelfreak bastelfreak self-assigned this Jul 9, 2025
@bastelfreak bastelfreak added the enhancement New feature or request label Jul 9, 2025
@bastelfreak
Copy link
Copy Markdown
Contributor Author

ah derp, the error is coming from openfact:

/home/runner/work/openvoxserver-ca/openvoxserver-ca/vendor/bundle/ruby/3.4.0/gems/openfact-5.0.0/lib/facter/framework/core/file_loader.rb:9: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
/home/runner/work/openvoxserver-ca/openvoxserver-ca/vendor/bundle/ruby/3.4.0/gems/openfact-5.0.0/lib/facter/util/resolvers/ssh_helper.rb:3: warning: base64 was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0.

let me raise a PR there

@bastelfreak bastelfreak deleted the ruby34 branch July 10, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant