Skip to content

Commit 5743e4f

Browse files
committed
[CVE] remove nokogiri and dependencies
Nokogiri was used to bump performance on MacOS clients when parsing plist files. Without it, CFPropertyList will fall back to rexml. However, performance testing indicates that the boost is negligible. This just removes it and reduces our security exposure. This removes the libxml2 & libxslt libraries from the agent runtime, but doesn't actually delete the components yet because Bolt uses them.
1 parent ca7f535 commit 5743e4f

4 files changed

Lines changed: 0 additions & 51 deletions

File tree

configs/components/rubygem-mini_portile2.rb

Lines changed: 0 additions & 13 deletions
This file was deleted.

configs/components/rubygem-nokogiri.rb

Lines changed: 0 additions & 30 deletions
This file was deleted.

configs/projects/_shared-agent-components.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@
3535
proj.component "ruby-#{proj.ruby_version}"
3636
proj.component "readline" if platform.is_macos?
3737
proj.component 'augeas' unless platform.is_windows?
38-
proj.component 'libxml2' unless platform.is_windows?
39-
proj.component 'libxslt' unless platform.is_windows?
4038

4139
proj.component 'ruby-augeas' unless platform.is_windows?
4240
proj.component 'ruby-shadow' unless platform.is_aix? || platform.is_windows?

configs/projects/agent-runtime-main.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,6 @@
6767
proj.component 'rubygem-sys-filesystem'
6868
end
6969

70-
# Nokogiri and dependencies to improve macOS performance (PUP-11332)
71-
if platform.is_macos?
72-
proj.component 'rubygem-nokogiri'
73-
proj.component 'rubygem-mini_portile2'
74-
end
75-
7670
# Dependencies for gettext for Ruby >= 3.2 (PA-4815)
7771
proj.component 'rubygem-erubi'
7872
proj.component 'rubygem-prime'

0 commit comments

Comments
 (0)