Skip to content

Commit 91cd21c

Browse files
committed
Use git describe instead of ref
If we build against HEAD of a branch name and that branch has a disallowed character, the upload artifacts step fails. This uses the git describe on the repo instead, which matches the names of the files vanagon creates as well.
1 parent 01a2aa4 commit 91cd21c

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

.github/workflows/build_vanagon.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,15 +180,17 @@ jobs:
180180
- name: Bundle install
181181
run: bundle install --retry=3
182182

183-
- name: Run build script
183+
- name: Run build script and save git describe
184+
id: build
184185
run: |-
185186
rm -rf output
187+
echo "describe=$(git describe --abbrev=9)" >> $GITHUB_OUTPUT
186188
bundle exec rake vox:build['${{ inputs.project_name }}','${{ matrix.platform }}']
187189
188190
- name: Upload build artifacts
189191
uses: actions/upload-artifact@v4
190192
with:
191-
name: build-artifacts-${{ inputs.ref }}-${{ matrix.platform }}
193+
name: build-artifacts-${{ steps.build.outputs.describe }}-${{ matrix.platform }}
192194
path: output/
193195

194196
- name: Upload output to S3
@@ -200,4 +202,4 @@ jobs:
200202
# https://github.com/boto/boto3/issues/4398#issuecomment-2619946229
201203
AWS_REQUEST_CHECKSUM_CALCULATION: "WHEN_REQUIRED"
202204
AWS_RESPONSE_CHECKSUM_VALIDATION: "WHEN_REQUIRED"
203-
run: bundle exec rake vox:upload['${{ inputs.ref }}','${{ matrix.platform }}']
205+
run: bundle exec rake vox:upload['${{ steps.build.outputs.describe }}','${{ matrix.platform }}']

0 commit comments

Comments
 (0)