fix: reject empty recordings on retry, restore push-to-talk under compositor shortcuts#1065
Open
xAlcahest wants to merge 2 commits into
Open
fix: reject empty recordings on retry, restore push-to-talk under compositor shortcuts#1065xAlcahest wants to merge 2 commits into
xAlcahest wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The double-trigger behind #864 left a lasting scar: header-only recordings (~110 bytes) saved to history by older builds fail every Retry/Recover with the same confusing "Audio file might be corrupted or unsupported", because the
retry-transcriptionhandler inipcHandlers.jsships the stored buffer to a backend with no validation. The handler now rejects buffers smaller thanMIN_AUDIO_BYTES(reusingisEmptyRecordingfromrecordingGuard.js) and returns a clear "Recording contains no audio" instead.The
reconcileNativeKeyListenersgate from #1001 also turned out to kill push-to-talk on KDE/GNOME/Hyprland: it blanks the native key listener whenever the compositor owns the hotkeys, but in push mode the compositor callback intentionally early-returns to defer to that same listener, so holding the hotkey did nothing at all.getNativeListenerKeysnow takes acompositorOwnsHotkeysflag and keeps just the dictation key watched in push mode; tap slots stay compositor-delivered, so the original double-trigger cannot come back. Verified on KDE Plasma Wayland (Fedora 44): tap unchanged, hold works again.Fixes #864 #847
Changes
Supersedes #872.