ci(macos): Add App Bundle artifacts and runtime data discovery#2050
Closed
TmLev wants to merge 2 commits into
Closed
ci(macos): Add App Bundle artifacts and runtime data discovery#2050TmLev wants to merge 2 commits into
TmLev wants to merge 2 commits into
Conversation
- Add macOS Release CI step that creates OpenXRay.app plus .app.zip and .dmg artifacts - Install `dylibbundler` on macOS runners and include bundle step success in artifact upload gating - Add `misc/macos/make_app_bundle.sh` to assemble bundle, bundle dylibs, and package outputs - Bundle only open-source resources from repository (`res/fsgame.ltx` and `res/gamedata`), no proprietary game assets - Add macOS runtime best-effort data resolution for app bundles: check App Support, app-neighbor root, common install paths, then prompt user to choose folder - When bundle resources exist, use in-bundle openxray resources for `fsgame.ltx` and shaders symlink targets
Xottab-DUTY
reviewed
Feb 11, 2026
Xottab-DUTY
left a comment
Xottab-DUTY
left a comment
Member
There was a problem hiding this comment.
Is it possible to reuse the functionality available in CMake?
| xr_sprintf(tmp_link, "%s/fsgame.ltx", resourcesRoot); | ||
| else | ||
| #endif | ||
| xr_sprintf(tmp_link, "%s/openxray/fsgame.ltx", CMAKE_INSTALL_FULL_DATAROOTDIR); |
Member
There was a problem hiding this comment.
Always enclose the else body into {} when if and else are under the #ifdef.
Suggested change
| xr_sprintf(tmp_link, "%s/openxray/fsgame.ltx", CMAKE_INSTALL_FULL_DATAROOTDIR); | |
| { | |
| xr_sprintf(tmp_link, "%s/openxray/fsgame.ltx", CMAKE_INSTALL_FULL_DATAROOTDIR); | |
| } |
| xr_sprintf(tmp_link, "%s/gamedata/shaders/gl", resourcesRoot); | ||
| else | ||
| #endif | ||
| xr_sprintf(tmp_link, "%s/openxray/gamedata/shaders/gl", CMAKE_INSTALL_FULL_DATAROOTDIR); |
Member
There was a problem hiding this comment.
Always enclose the else body into {} when if and else are under the #ifdef.
Suggested change
| xr_sprintf(tmp_link, "%s/openxray/gamedata/shaders/gl", CMAKE_INSTALL_FULL_DATAROOTDIR); | |
| { | |
| xr_sprintf(tmp_link, "%s/openxray/gamedata/shaders/gl", CMAKE_INSTALL_FULL_DATAROOTDIR); | |
| } |
Contributor
Author
|
Appreciate the early review, but this is still in draft :) |
Contributor
Author
|
Superseded by #2090. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add macOS Release CI step that creates OpenXRay.app plus .app.zip and .dmg artifacts
Install
dylibbundleron macOS runners and include bundle step success in artifact upload gatingAdd
misc/macos/make_app_bundle.shto assemble bundle, bundle dylibs, and package outputsBundle only open-source resources from repository (
res/fsgame.ltxandres/gamedata), no proprietary game assetsAdd macOS runtime best-effort data resolution for app bundles: check App Support, app-neighbor root, common install paths, then prompt user to choose folder
When bundle resources exist, use in-bundle openxray resources for
fsgame.ltxand shaders symlink targets