[N-01] Access Control Audit

[ericnordelo]

Summary by CodeRabbit

• Bug Fixes

  • Fixed admin role transfer and renounce flows to properly refresh pending delays before scheduling new actions.

• Improvements

  • Enhanced role and admin change events with improved type parameterization for better tracking and filtering.
  • Admin delay getter now computes effective delays by accounting for pending changes and elapsed time.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 315f53ac-e445-4cc6-916e-c68739f27225

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/access-control-N-001

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.88%. Comparing base (3bdd7f2) to head (30672bc).

Files with missing lines	Patch %	Lines
contracts/access/sources/access_control.move	91.66%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-v1.2     #339      +/-   ##
================================================
+ Coverage         95.83%   95.88%   +0.05%     
================================================
  Files                22       22              
  Lines              2208     2214       +6     
  Branches            602      600       -2     
================================================
+ Hits               2116     2123       +7     
+ Misses               68       67       -1     
  Partials             24       24              

Flag	Coverage Δ
contracts/access	65.40% <91.66%> (+0.46%)	⬆️
math/core	86.12% <ø> (ø)
math/fixed_point	55.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR updates access_control to align event identity with the RootRole type and reworks default-admin delay changes so elapsed pending changes are reflected automatically by delay-aware calls.

Changes:

• Parameterizes access-control events by RootRole and removes duplicated sender fields.
• Replaces explicit delay-change acceptance with effective-delay lookup and refresh-on-mutation behavior.
• Emits cancellation events when pending admin or delay-change actions are overwritten, with updated test coverage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
contracts/access/sources/access_control.move	Updates event types/emissions and default-admin delay-change lifecycle semantics.
contracts/access/tests/access_control_tests.move	Updates event assertions and adds coverage for automatic delay materialization and overwrite cancellation events.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bidzyyys]

LGTM

[immrsd]

LGTM! Left just a single comment regarding the cancellation events

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.