Skip to content

Stellar vault#61

Merged
ozgunozerk merged 9 commits into
mainfrom
stellar-vault
Nov 4, 2025
Merged

Stellar vault#61
ozgunozerk merged 9 commits into
mainfrom
stellar-vault

Conversation

@ozgunozerk
Copy link
Copy Markdown
Contributor

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 21, 2025

Deploy Preview for openzeppelin-docs-v2 failed. Why did it fail? →

Name Link
🔨 Latest commit 9dd2daa
🔍 Latest deploy log https://app.netlify.com/projects/openzeppelin-docs-v2/deploys/690a12a83185650008a0ec70

@ozgunozerk ozgunozerk marked this pull request as ready for review November 3, 2025 13:32
@ozgunozerk ozgunozerk requested a review from brozorec November 3, 2025 13:32
@ozgunozerk
Copy link
Copy Markdown
Contributor Author

ozgunozerk commented Nov 3, 2025

@brozorec I'll resolve the conflicts later, i requested review only on the content of the main document to save time 👍

@ozgunozerk ozgunozerk self-assigned this Nov 4, 2025
Copy link
Copy Markdown
Contributor

@brozorec brozorec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add "Vault" in the navigation
  2. You're using "Vault Token", but isn't it more commonly referred as "Token Vault" 🤔
  3. Review links as it's not in "extensions" any more
  4. Should we also add a basic "Usage" section at the end where showing how to implement it?

Comment thread content/stellar-contracts/tokens/vault/vault.mdx
Comment thread content/stellar-contracts/tokens/vault/vault.mdx Outdated
Comment thread content/stellar-contracts/tokens/vault/vault.mdx Outdated
Comment thread content/stellar-contracts/tokens/vault/vault.mdx
Comment thread content/stellar-contracts/tokens/vault/vault.mdx Outdated
@ozgunozerk ozgunozerk requested a review from brozorec November 4, 2025 11:11
Copy link
Copy Markdown
Contributor

@brozorec brozorec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread content/stellar-contracts/tokens/vault/vault.mdx Outdated
@ozgunozerk ozgunozerk merged commit 259fdb0 into main Nov 4, 2025
2 of 6 checks passed
@son-oz son-oz deleted the stellar-vault branch May 8, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants