Provide two variant of ERC4626Fees with different models#8
Open
Amxx wants to merge 6 commits into
Open
Conversation
Amxx
commented
Jul 30, 2024
Amxx
commented
Jul 30, 2024
Amxx
force-pushed
the
refactor/erc4626fees
branch
from
5636637 to
2be359f
Compare
…ppelin-contracts-experimental into refactor/erc4626fees
Amxx
force-pushed
the
refactor/erc4626fees
branch
from
2be359f to
1be9def
Compare
ernestognw
previously approved these changes
Jul 30, 2024
ernestognw
left a comment
ernestognw
left a comment
Member
There was a problem hiding this comment.
I like the way this is exposed, it's clear both options are different and the description is good too. LGTM
Collaborator
Author
This should be taken care of in the main contract (ERC4626) using pr #5130 of the main repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cairoeth lets do the
maxXxxxchanges here.