Skip to content

L-30: Make AccountERC7579 isModuleInstalled return false for the address zero module#6436

Closed
gonzaotc wants to merge 3 commits intoOpenZeppelin:masterfrom
gonzaotc:fix/L30-Account7579-isModuleInstalled-address0
Closed

L-30: Make AccountERC7579 isModuleInstalled return false for the address zero module#6436
gonzaotc wants to merge 3 commits intoOpenZeppelin:masterfrom
gonzaotc:fix/L30-Account7579-isModuleInstalled-address0

Conversation

@gonzaotc
Copy link
Copy Markdown
Contributor

@gonzaotc gonzaotc commented Mar 25, 2026

Fixes #????

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@gonzaotc gonzaotc requested a review from a team as a code owner March 25, 2026 16:24
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 25, 2026

🦋 Changeset detected

Latest commit: b65f4c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gonzaotc gonzaotc changed the title Make AccountERC7579 isModuleInstalled return false for the address zero module L30: Make AccountERC7579 isModuleInstalled return false for the address zero module Mar 25, 2026
@gonzaotc gonzaotc changed the title L30: Make AccountERC7579 isModuleInstalled return false for the address zero module L-30: Make AccountERC7579 isModuleInstalled return false for the address zero module Mar 25, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c65ce007-84f4-464a-9702-8ea3f13597a4

📥 Commits

Reviewing files that changed from the base of the PR and between ef5a2d0 and b65f4c2.

📒 Files selected for processing (4)
  • .changeset/fifty-owls-boil.md
  • contracts/account/extensions/draft-AccountERC7579.sol
  • contracts/account/extensions/draft-AccountERC7579Hooked.sol
  • test/account/extensions/AccountERC7579.behavior.js

Walkthrough

This change updates the isModuleInstalled function across account abstraction contracts to explicitly return false when querying for module installation status with the zero address. Modifications are made to the fallback-handler branch in draft-AccountERC7579.sol and the hook module type handling in draft-AccountERC7579Hooked.sol. A new test case was added to verify the zero address returns false for all supported module types. A changeset file was added to record this as a patch-level fix.

Possibly related PRs

Suggested labels

bug, ignore-changeset, Account Abstraction

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a zero address check to the isModuleInstalled function in AccountERC7579.
Description check ✅ Passed The description is related to the changeset, referencing the PR objectives and checklist items, though it lacks detailed implementation context.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Amxx
Copy link
Copy Markdown
Collaborator

Amxx commented Mar 25, 2026

I'm pretty sure this breaks the Certora FV.
we need to push that branch to the OZ repo (not our personal forks) so we can run FV on it.

@gonzaotc
Copy link
Copy Markdown
Contributor Author

See #6439

@gonzaotc gonzaotc closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants