Add ESLint rule to disallow async describe blocks

[Sanenelisiwe1975]

Mocha ignores the returned Promise from async describe callbacks, which silently swallows any rejections thrown directly in the describe body. Add eslint-plugin-mocha with the mocha/no-async-suite rule to enforce this going forward, and fix the three existing violations.

Fixes #4943

Mocha ignores the returned Promise from async describe callbacks, which silently swallows any rejections thrown directly in the describe body. Add eslint-plugin-mocha with the mocha/no-async-suite rule to enforce this going forward, and fix the three existing violations.

Fixes #4943

PR Checklist

• [x ] Tests-the ESLint rule itself enforces correctness going forward; no new unit tests needed for a linting rule
• Documentation
• [x ] Changeset entry (run npx changeset add)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 948bd60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​eslint-plugin-mocha@​11.2.0

View full report

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2eb1de94-6698-490d-b471-59ea818fb550

📥 Commits

Reviewing files that changed from the base of the PR and between 9cfdccd and 948bd60.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (5)

• eslint.config.mjs
• package.json
• test/access/manager/AccessManager.test.js
• test/crosschain/BridgeERC1155.behavior.js
• test/token/ERC6909/ERC6909.behavior.js

---

Walkthrough

Introduces ESLint rule enforcement via eslint-plugin-mocha to prevent async test suite declarations. Updates eslint.config.mjs to import the plugin and register the mocha/no-async-suite rule at error level. Adds eslint-plugin-mocha ^11.2.0 as a dev dependency. Removes async modifiers from three describe block callbacks in test files to comply with the new linting rule.

Suggested labels

tests

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding an ESLint rule to disallow async describe blocks, which is the primary objective of this PR.
Description check	✅ Passed	The description is directly related to the changeset, explaining the rationale for the change and linking to the relevant issue #4943.
Linked Issues check	✅ Passed	The PR fully addresses the objective from #4943: eslint-plugin-mocha is added, the mocha/no-async-suite rule is enabled, and three existing violations are fixed.
Out of Scope Changes check	✅ Passed	All changes directly support the objective of enabling the ESLint rule and fixing violations. No out-of-scope modifications are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gonzaotc]

Already solved at #6438