Skip to content

feat: Plat-6681 expose crud api endpoints#365

Merged
zeljkoX merged 69 commits into
mainfrom
plat-6681-expose-crud-api-endpoints-2
Jul 31, 2025
Merged

feat: Plat-6681 expose crud api endpoints#365
zeljkoX merged 69 commits into
mainfrom
plat-6681-expose-crud-api-endpoints-2

Conversation

@zeljkoX
Copy link
Copy Markdown
Collaborator

@zeljkoX zeljkoX commented Jul 17, 2025

Summary

Parent branch that contains all work regarding exposing CRUD endpoints.

Work included:

  • Introduced CRUD API endpoints for signers, notifications and relayers
  • Removed vault_cloud signer support due to service being deprecated
  • Implemented logic for securely persisting secrets in redis
  • Refactored models to use domain models for validations given we have two entry points (config, api request). Request and Config models are converted to domain and validated.
  • Allowed starting service without requiring resources to be defined in config file
  • Storage agnostic transaction expiration logic
  • Documentation

It should be merged once all CRUD endpoints are implemented.

PRs that are part of this branch:

Testing Process

Checklist

  • Add a reference to related issues in the PR description.
  • Add unit tests if applicable.

@zeljkoX zeljkoX changed the title [DRAFT] feat: Plat-6681 expose crud api endpoints feat: Plat-6681 expose crud api endpoints Jul 29, 2025
@zeljkoX zeljkoX marked this pull request as ready for review July 29, 2025 09:51
@zeljkoX zeljkoX requested review from a team as code owners July 29, 2025 09:51
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 92.71329% with 398 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.6%. Comparing base (97a8698) to head (f4fa14f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/api/controllers/relayer.rs 65.0% 121 Missing ⚠️
src/models/relayer/mod.rs 96.6% 45 Missing ⚠️
src/models/relayer/config.rs 94.9% 44 Missing ⚠️
src/models/relayer/request.rs 95.9% 33 Missing ⚠️
src/api/routes/notification.rs 27.2% 32 Missing ⚠️
src/api/routes/signer.rs 27.9% 31 Missing ⚠️
src/models/notification/config.rs 91.4% 20 Missing ⚠️
src/models/relayer/repository.rs 97.7% 15 Missing ⚠️
src/api/routes/relayer.rs 69.5% 14 Missing ⚠️
src/api/controllers/signer.rs 94.7% 9 Missing ⚠️
... and 11 more
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #365     +/-   ##
=======================================
+ Coverage   88.4%   92.6%   +4.2%     
=======================================
  Files        210     214      +4     
  Lines      67457   69159   +1702     
=======================================
+ Hits       59663   64079   +4416     
+ Misses      7794    5080   -2714     
Flag Coverage Δ
integration 0.5% <0.0%> (+<0.1%) ⬆️
properties <0.1% <0.0%> (+<0.1%) ⬆️
unittests 92.6% <92.7%> (+0.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/api/routes/network.rs Outdated
@@ -0,0 +1 @@

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something happen here

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it, thanks for noticing

@zeljkoX zeljkoX merged commit f3c3426 into main Jul 31, 2025
23 of 24 checks passed
@zeljkoX zeljkoX deleted the plat-6681-expose-crud-api-endpoints-2 branch July 31, 2025 06:49
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants