Skip to content

feat: Add Arbitrum support#373

Merged
NicoMolinaOZ merged 13 commits into
mainfrom
plat-6387-add-arbitrum-support
Jul 24, 2025
Merged

feat: Add Arbitrum support#373
NicoMolinaOZ merged 13 commits into
mainfrom
plat-6387-add-arbitrum-support

Conversation

@NicoMolinaOZ
Copy link
Copy Markdown
Contributor

@NicoMolinaOZ NicoMolinaOZ commented Jul 18, 2025

Summary

  • Adding extra logic for Arbitrum based chains

Testing Process

Checklist

  • Add a reference to related issues in the PR description.
  • Add unit tests if applicable.

Copy link
Copy Markdown
Collaborator

@zeljkoX zeljkoX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Few comments...

Comment thread src/domain/transaction/evm/status.rs Outdated
Comment thread src/domain/transaction/evm/status.rs Outdated
Comment thread src/domain/transaction/evm/utils.rs Outdated
Comment thread config/networks/arbitrum.json
Comment thread src/domain/transaction/evm/status.rs
Comment thread src/domain/transaction/evm/utils.rs Outdated
Comment thread src/domain/transaction/evm/utils.rs Outdated
@NicoMolinaOZ NicoMolinaOZ marked this pull request as ready for review July 21, 2025 19:04
@NicoMolinaOZ NicoMolinaOZ requested review from a team as code owners July 21, 2025 19:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 96.64948% with 26 lines in your changes missing coverage. Please review.

Project coverage is 88.4%. Comparing base (5e1c0c8) to head (018740f).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
src/domain/transaction/evm/price_calculator.rs 94.6% 18 Missing ⚠️
src/domain/transaction/evm/status.rs 96.4% 7 Missing ⚠️
src/domain/transaction/evm/utils.rs 99.5% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #373     +/-   ##
=======================================
+ Coverage   88.1%   88.4%   +0.2%     
=======================================
  Files        210     210             
  Lines      65576   67457   +1881     
=======================================
+ Hits       57836   59663   +1827     
- Misses      7740    7794     +54     
Flag Coverage Δ
integration 0.5% <0.0%> (-0.1%) ⬇️
properties <0.1% <0.0%> (?)
unittests 91.8% <96.6%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/models/network/evm/network.rs Outdated
Comment thread config/networks/arbitrum.json Outdated
Comment thread config/networks/arbitrum.json Outdated
Comment thread config/networks/arbitrum.json Outdated
Comment thread docs/modules/ROOT/pages/network_configuration.adoc Outdated
Comment thread config/networks/optimism.json Outdated
"tags": [
"arbitrum_based",
"rollup",
"no-mempool"
Copy link
Copy Markdown
Collaborator

@zeljkoX zeljkoX Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially we do not need no-mempool tag with introduction of arbitrum_based tag. I do not see need for existance of no-mempool tag.

We can simply calculate lacks_mempool return value based on other tag/s for example.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I agree, but for this PR, lets keep that simple.
I will address that issue later on, but I will keep no-mempool so users can have a way to test that.
PLAT-6876 is the ticket for that.

Comment thread src/domain/transaction/evm/status.rs Outdated
Comment thread src/domain/transaction/evm/price_calculator.rs Outdated
Comment thread config/networks/arbitrum.json
Comment thread config/networks/arbitrum.json
Comment thread config/networks/arbitrum.json
Comment thread docs/modules/ROOT/pages/network_configuration.adoc
Comment thread src/models/network/evm/network.rs
Copy link
Copy Markdown
Collaborator

@zeljkoX zeljkoX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Small changes needed.

@NicoMolinaOZ NicoMolinaOZ merged commit 7b5372b into main Jul 24, 2025
23 of 24 checks passed
@NicoMolinaOZ NicoMolinaOZ deleted the plat-6387-add-arbitrum-support branch July 24, 2025 13:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants