feat: Add Arbitrum support#373
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
+ Coverage 88.1% 88.4% +0.2%
=======================================
Files 210 210
Lines 65576 67457 +1881
=======================================
+ Hits 57836 59663 +1827
- Misses 7740 7794 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "tags": [ | ||
| "arbitrum_based", | ||
| "rollup", | ||
| "no-mempool" |
There was a problem hiding this comment.
Potentially we do not need no-mempool tag with introduction of arbitrum_based tag. I do not see need for existance of no-mempool tag.
We can simply calculate lacks_mempool return value based on other tag/s for example.
There was a problem hiding this comment.
I think I agree, but for this PR, lets keep that simple.
I will address that issue later on, but I will keep no-mempool so users can have a way to test that.
PLAT-6876 is the ticket for that.
zeljkoX
left a comment
There was a problem hiding this comment.
Looks good. Small changes needed.
Summary
Testing Process
Checklist