Skip to content

fix: plat-6888 aws kms signer issue#411

Merged
zeljkoX merged 4 commits into
mainfrom
plat-6888-aws-kms-bug-reported-via-telegram
Aug 6, 2025
Merged

fix: plat-6888 aws kms signer issue#411
zeljkoX merged 4 commits into
mainfrom
plat-6888-aws-kms-bug-reported-via-telegram

Conversation

@zeljkoX
Copy link
Copy Markdown
Collaborator

@zeljkoX zeljkoX commented Aug 6, 2025

Summary

This PR addresses issues related to the usage of the AWS KMS signer.

Fixes and Improvements:

  • recover_public_key fix: Previously, only the value 0 was used for recovery, resulting in errors. This has been corrected.
  • Public key normalization: The DER-encoded public key is now normalized to a low-S value to comply with standard requirements.
  • Caching enhancement: Improved caching mechanism for the AWS KMS DER public key to enhance performance.

Testing Process

Checklist

  • Add a reference to related issues in the PR description.
  • Add unit tests if applicable.

@zeljkoX zeljkoX requested review from a team as code owners August 6, 2025 11:01
Comment thread src/services/aws_kms/mod.rs Fixed
Comment thread src/services/aws_kms/mod.rs Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.6%. Comparing base (648a0f1) to head (700a57f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/services/aws_kms/mod.rs 20.0% 12 Missing ⚠️
src/utils/secp256k.rs 66.6% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.3%) is below the target coverage (90.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #411     +/-   ##
=======================================
- Coverage   92.6%   92.6%   -0.1%     
=======================================
  Files        216     216             
  Lines      70950   70961     +11     
=======================================
- Hits       65751   65750      -1     
- Misses      5199    5211     +12     
Flag Coverage Δ
integration 0.5% <0.0%> (-0.1%) ⬇️
properties <0.1% <0.0%> (-0.1%) ⬇️
unittests 92.6% <33.3%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/utils/secp256k.rs Outdated
zeljkoX and others added 3 commits August 6, 2025 13:25
Co-authored-by: Luis Sebastian Urrutia Fuentes <luis@urrutia.me>
@zeljkoX zeljkoX merged commit 3c12c88 into main Aug 6, 2025
22 of 24 checks passed
@zeljkoX zeljkoX deleted the plat-6888-aws-kms-bug-reported-via-telegram branch August 6, 2025 13:42
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants