feat: Add Launctube plugin example#414
Conversation
Signed-off-by: Dylan Kilkenny <dylankilkenny95@gmail.com>
Signed-off-by: Dylan Kilkenny <dylankilkenny95@gmail.com>
| "path": "config/keys/launchtube-seq-001.json", | ||
| "passphrase": { | ||
| "type": "env", | ||
| "value": "KEYSTORE_PASSPHRASE" |
There was a problem hiding this comment.
Why these signers use same keystore file password?
It can be KEYSTORE_PASSPHRASE_SEQ_001?
| "path": "config/keys/launchtube-seq-002.json", | ||
| "passphrase": { | ||
| "type": "env", | ||
| "value": "KEYSTORE_PASSPHRASE" |
|
|
||
| ```env | ||
| REDIS_URL=redis://redis:6379 | ||
| KEYSTORE_PASSPHRASE=YOUR_PASSWORD |
There was a problem hiding this comment.
let's use different keystore passphrases to ensure best practices are followed
zeljkoX
left a comment
zeljkoX
left a comment
There was a problem hiding this comment.
Looks good in overall. Let's just improve keystore passphrases handling and ensure we are using different passphrases per signer.
tirumerla
left a comment
tirumerla
left a comment
There was a problem hiding this comment.
Overall lgtm, added a minor comment. Agree with ze's comment on using different keystore passwords.
|
|
||
| **Parameters:** | ||
|
|
||
| - `xdr`: Complete transaction envelope XDR |
There was a problem hiding this comment.
May be better to add references to documentation/snippets in stellar-sdk on how to get tx envelope xdr.
Signed-off-by: Dylan Kilkenny <dylankilkenny95@gmail.com>
Signed-off-by: Dylan Kilkenny <dylankilkenny95@gmail.com>
| environment: API_KEY | ||
| webhook_signing_key: | ||
| environment: WEBHOOK_SIGNING_KEY | ||
| keystore_passphrase: |
There was a problem hiding this comment.
I think you need to define new envars here
| RATE_LIMIT_BURST: 50 | ||
| WEBHOOK_SIGNING_KEY: ${WEBHOOK_SIGNING_KEY} | ||
| API_KEY: ${API_KEY} | ||
| KEYSTORE_PASSPHRASE: ${KEYSTORE_PASSPHRASE} |
There was a problem hiding this comment.
and here to pass to image
4 participants
Summary
Adds a working example for running OpenZeppelin Relayer with the LaunchTube plugin.
Changes:
Testing Process
Checklist