feat: Enhance Stellar with concurrent transaction support#423
Merged
Conversation
Signed-off-by: Dylan Kilkenny <dylankilkenny95@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
======================================
Coverage 92.7% 92.7%
======================================
Files 217 217
Lines 73093 73295 +202
======================================
+ Hits 67788 67992 +204
+ Misses 5305 5303 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zeljkoX
approved these changes
Aug 14, 2025
|
|
||
| pub fn concurrent_transactions_enabled(&self) -> bool { | ||
| if let RelayerNetworkPolicy::Stellar(policy) = &self.relayer().policies { | ||
| policy.concurrent_transactions.unwrap_or(false) |
Collaborator
There was a problem hiding this comment.
maybe to define constant with default value.
Collaborator
There was a problem hiding this comment.
With upcoming Stellar work I wonder it okay to use false as default value?
Member
Author
There was a problem hiding this comment.
Added! Best to keep false as default as only with special transaction operations will concurrency work
Signed-off-by: Dylan Kilkenny <dylankilkenny95@gmail.com>
Signed-off-by: Dylan Kilkenny <dylankilkenny95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concurrent_transactionsoption to Stellar relayer policies, allowing for parallel processing of transactions. Set on a per relayer basis.concurrent_transactionsflag and allow concurrent processing.Testing Process
Checklist