docs: Ensured Ubuntu (Unix) Compatibility#429
Conversation
WalkthroughUpdated README.md with two Debian/Ubuntu-specific notes: installing build-essential after libsodium steps, and installing libssl-dev and pkg-config after the key-generation example to prevent OpenSSL-related errors. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
All contributors have signed the CLA ✍️ ✅ |
|
I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
255-256: Polish Debian/Ubuntu note: fix grammar, remove extra spacing, and use a copy-pastable command block.Current sentence has casing issues (“On”), extra spaces around the slash, and embeds the apt command inline. Suggest making it concise and consistent with the rest of the README by using a fenced bash block and including apt-get update and -y for smoother UX.
- > **Note**: To compile On Debian/ Ubuntu, you must install the `build-essential` by running `sudo apt-get install build-essential` if it's missing. + > Note (Debian/Ubuntu): If you're compiling libsodium from source, install build-essential first. + ```bash + sudo apt-get update && sudo apt-get install -y build-essential + ```
329-330: Update Debian/Ubuntu installation instructions for OpenSSLTo make the OpenSSL hint more visible and consistent (and to reduce friction on fresh installs), switch from the inline command to a fenced bash block that includes
apt-get updateand the-yflag.• File: README.md
• Lines: 329–330- > :warning: On Ubuntu/ Debian, if you encounter OpenSSL errors, install the `libssl-dev` and `pkg-config` packages: `sudo apt-get install libssl-dev pkg-config` + > :warning: Debian/Ubuntu: If you encounter OpenSSL build errors, install the required packages: + > + > ```bash + > sudo apt-get update && sudo apt-get install -y pkg-config libssl-dev + > ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules - openzeppelin-relayer
- GitHub Check: Header rules - openzeppelin-relayer
- GitHub Check: Pages changed - openzeppelin-relayer
- GitHub Check: semgrep/ci
zeljkoX
left a comment
There was a problem hiding this comment.
Thank you for your contribution and time spent testing!
LGTM!
|
@tirumerla I've updated the PR title. What signed commit are you referring to? |
Looks like some of the commits are unverified. You will need to rebase commits with signed ammends. |
|
@0x-ximon could you also please take care of nits from code rabbit #429 (review). Thanks |
|
@tirumerla I recently switched upgraded my Debian OS and switched out GPG keys so that explains the unverified commits. I might have to close this PR and create a new one with all commits verified. What do you think? |
Sure sounds good with me |

Summary
Updated README with notes and tips on how to build on Debian/ Ubuntu. Addresses issue: #360
Testing Process
build-essentialin order to compile thelibsodiumpackage.libssl-dev pkg-configpackages.Checklist
Summary by CodeRabbit