chore: Bump Rust toolchain to 1.91.1 by tirumerla · Pull Request #767 · OpenZeppelin/openzeppelin-relayer

tirumerla · 2026-05-07T23:51:58Z

Resolves cargo-doc build failure on Netlify caused by locked deps rustc >= 1.91.1.

rust-toolchain.toml: 1.88.0 -> 1.91.1
Cargo.toml MSRV: 1.88 -> 1.91
Bump 1.91.1 in github actions workflows
Apply new clippy lints from 1.91

Summary by CodeRabbit

Chores
- Updated minimum supported Rust toolchain version to 1.91.1 for improved compatibility and performance.
Refactor
- Internal code optimizations across message queue worker and data repositories to improve efficiency.

coderabbitai · 2026-05-07T23:52:11Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0a9de7d-ea28-4ce5-8c9b-187e80b5d6a3

📥 Commits

Reviewing files that changed from the base of the PR and between 4bfd68d and eb734cd.

📒 Files selected for processing (13)

.github/actions/prepare/action.yml
Cargo.toml
rust-toolchain.toml
src/jobs/handlers/transaction_cleanup_handler.rs
src/queues/sqs/worker.rs
src/repositories/api_key/api_key_in_memory.rs
src/repositories/network/network_in_memory.rs
src/repositories/notification/notification_in_memory.rs
src/repositories/plugin/plugin_in_memory.rs
src/repositories/relayer/relayer_in_memory.rs
src/repositories/signer/signer_in_memory.rs
src/repositories/transaction/transaction_in_memory.rs
src/services/plugins/pool_executor.rs

Walkthrough

This PR upgrades Rust from version 1.88 to 1.91.1 across CI, workspace manifest, and local toolchain configuration. Seven in-memory repository modules are updated with explicit lifetime parameters in their internal lock helpers for compiler compatibility. Three independent code quality improvements optimize memory allocation and standardize conditional logic patterns.

Changes

Rust 1.91 Upgrade and Repository Compatibility

Layer / File(s)	Summary
Toolchain Configuration `.github/actions/prepare/action.yml`, `Cargo.toml`, `rust-toolchain.toml`	Rust version synchronized to 1.91.1 across CI workflow, workspace MSRV, and local toolchain.
Repository Lifetime Corrections `src/repositories/api_key/api_key_in_memory.rs`, `src/repositories/network/network_in_memory.rs`, `src/repositories/notification/notification_in_memory.rs`, `src/repositories/plugin/plugin_in_memory.rs`, `src/repositories/relayer/relayer_in_memory.rs`, `src/repositories/signer/signer_in_memory.rs`, `src/repositories/transaction/transaction_in_memory.rs`	Internal `acquire_lock` helper functions updated from `MutexGuard<T>` to `MutexGuard<'_, T>` across all in-memory repositories for Rust 1.91 compatibility.

Code Quality and Logic Improvements

Layer / File(s)	Summary
Logic Optimizations `src/jobs/handlers/transaction_cleanup_handler.rs`, `src/queues/sqs/worker.rs`, `src/services/plugins/pool_executor.rs`	Transaction cleanup uses `std::slice::from_ref` to avoid clone. SQS recovery probe refactored with `is_multiple_of` and `>= 7` threshold. Pool executor stderr rate-limiting uses `is_multiple_of` for consistency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A toolchain hops from eighty-eight to ninety-one,
Lifetimes bloom explicit, compiler's work is done,
From clone to slice::ref, the code runs lean and true,
Logic cleaner, patterns bright—a fresh Rust morning's brew!
bounces with satisfaction 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description provides clear context about the reason for the change (Netlify build failure), specific version updates, and code improvements, but does not follow the repository's required template structure with Summary, Testing Process, and Checklist sections.	Reorganize the description to match the template: add 'Summary' and 'Testing Process' sections, include a proper checklist with the required items (issues reference and unit tests), and preserve the existing details within the appropriate sections.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: Bump Rust toolchain to 1.91.1' clearly and specifically summarizes the main change—upgrading the Rust toolchain version.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/bump-rust-toolchain-1.91

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-05-08T00:01:49Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (4bfd68d) to head (eb734cd).

Additional details and impacted files

Flag	Coverage Δ
ai	`0.00% <0.00%> (ø)`
dev	`90.31% <100.00%> (-0.01%)`	⬇️
properties	`0.01% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   90.32%   90.31%   -0.01%     
==========================================
  Files         291      291              
  Lines      124502   124510       +8     
==========================================
- Hits       112454   112451       -3     
- Misses      12048    12059      +11

Files with missing lines	Coverage Δ
src/jobs/handlers/transaction_cleanup_handler.rs	`86.40% <100.00%> (ø)`
src/queues/sqs/worker.rs	`53.62% <100.00%> (ø)`
src/repositories/api_key/api_key_in_memory.rs	`94.44% <100.00%> (ø)`
src/repositories/network/network_in_memory.rs	`91.38% <100.00%> (ø)`
...epositories/notification/notification_in_memory.rs	`79.31% <100.00%> (ø)`
src/repositories/plugin/plugin_in_memory.rs	`99.61% <100.00%> (ø)`
src/repositories/relayer/relayer_in_memory.rs	`82.47% <100.00%> (ø)`
src/repositories/signer/signer_in_memory.rs	`79.16% <100.00%> (ø)`
.../repositories/transaction/transaction_in_memory.rs	`98.23% <100.00%> (ø)`
src/services/plugins/pool_executor.rs	`77.20% <100.00%> (ø)`

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chore: Bump Rust toolchain to 1.91.1

eb734cd

tirumerla requested a review from a team as a code owner May 7, 2026 23:51

github-actions Bot added the cla: allowlist label May 7, 2026

nahimterrazas approved these changes May 7, 2026

View reviewed changes

son-oz approved these changes May 8, 2026

View reviewed changes

tirumerla merged commit 8194752 into main May 8, 2026
26 of 27 checks passed

tirumerla deleted the chore/bump-rust-toolchain-1.91 branch May 8, 2026 00:36

github-actions Bot locked and limited conversation to collaborators May 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Bump Rust toolchain to 1.91.1#767

chore: Bump Rust toolchain to 1.91.1#767
tirumerla merged 1 commit into
mainfrom
chore/bump-rust-toolchain-1.91

tirumerla commented May 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 7, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

codecov Bot commented May 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tirumerla commented May 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

codecov Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tirumerla commented May 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 7, 2026 •

edited

Loading

codecov Bot commented May 8, 2026 •

edited

Loading