Skip to content

Add Sui Move support to develop-secure-contracts#11

Merged
bidzyyys merged 9 commits into
mainfrom
feat/develop-secure-sui
Jul 15, 2026
Merged

Add Sui Move support to develop-secure-contracts#11
bidzyyys merged 9 commits into
mainfrom
feat/develop-secure-sui

Conversation

@bidzyyys

@bidzyyys bidzyyys commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Extends the cross-ecosystem develop-secure-contracts skill with Sui Move, delivering the library-integration capability for Sui (consistent with the other ecosystems — no separate skill).

What it adds

  • .move detection in the project file-glob search.
  • Dependency resolution from Move.toml r.mvr (installed source under ~/.move/ + the build mirror; sui move build --doc for code docs).
  • A Sui Move row in the repository/documentation lookup table.
  • A note that Sui is deliberately not in the fixed category grid — discover its (growing) package set from llms.txt → the package catalogs → each package's README.md/examples/.
  • A Sui Move Integration Notes section: no CLI generator for Sui (use pattern discovery + examples/), and route conventions to their sources of truth — ARCHITECTURE.md (capability-based access, owned/shared objects), STYLEGUIDE.md (Move 2024 idioms), the package README.md (exact r.mvr snippet + use path), the docs site / API reference (signatures/params/aborts), and the setup-sui-contracts skill (toolchain, Move.toml, dependency-conflict override, builds, testing) — rather than restating them.

Methodology-first and discovery-driven: anything that drifts (slugs, module lists, patterns) is read from the library's own metadata, not hardcoded.

Notes

@bidzyyys bidzyyys mentioned this pull request Jul 3, 2026
Closed
@bidzyyys bidzyyys linked an issue Jul 3, 2026 that may be closed by this pull request
develop-secure-contracts: add Sui Move support OpenZeppelin/contracts-sui#422
Closed
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the existing develop-secure-contracts skill to cover Sui Move integration using the same “pattern discovery from installed dependency source + docs/examples” methodology used for other ecosystems.

Changes:

  • Adds .move to the project contract-file search globs.
  • Documents Sui Move dependency resolution via Move.toml + MVR and local doc generation via sui move build --doc.
  • Adds Sui Move to the repository/documentation lookup table and introduces a Sui-specific integration notes section emphasizing examples/metadata-driven discovery.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread skills/develop-secure-contracts/SKILL.md Outdated
@bidzyyys
bidzyyys requested a review from Copilot July 3, 2026 10:46
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread skills/develop-secure-contracts/SKILL.md Outdated
@bidzyyys
bidzyyys requested a review from Copilot July 3, 2026 11:53
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread skills/develop-secure-contracts/SKILL.md Outdated
Comment thread skills/develop-secure-contracts/SKILL.md Outdated
@bidzyyys
bidzyyys requested a review from Copilot July 3, 2026 12:18
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread skills/develop-secure-contracts/SKILL.md Outdated
@bidzyyys
bidzyyys requested a review from Copilot July 3, 2026 13:18
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@bidzyyys bidzyyys mentioned this pull request Jul 6, 2026
Merged
ericnordelo
ericnordelo approved these changes Jul 6, 2026
View reviewed changes

@ericnordelo ericnordelo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ericglau
ericglau requested changes Jul 14, 2026
View reviewed changes
Comment thread skills/develop-secure-contracts/SKILL.md Outdated
@bidzyyys bidzyyys mentioned this pull request Jul 15, 2026
Merged
Base automatically changed from feat/setup-sui-contracts to main July 15, 2026 09:33
bidzyyys added 4 commits July 15, 2026 11:46
@bidzyyys
develop-secure-contracts: add Sui Move support (#422)
10e54c4 
Extend the cross-ecosystem develop-secure-contracts skill with Sui Move,
delivering the library-integration capability for Sui (no separate skill,
consistent with the other ecosystems).

- detect `.move` in the project file-glob search
- resolve dependencies from Move.toml `r.mvr` (source under ~/.move/ and the
  build mirror; `sui move build --doc` for code docs)
- add a Sui Move row to the repository/documentation lookup table
- note that Sui is deliberately not in the fixed category grid — discover its
  package set from llms.txt -> catalogs -> package READMEs/examples
- add a Sui Move Integration Notes section: no CLI generator (use pattern
  discovery + examples), and route conventions to their sources of truth
  (ARCHITECTURE.md, STYLEGUIDE.md, package README, docs site / API reference,
  and the setup-sui-contracts skill) rather than restating them

Methodology-first and discovery-driven: specifics that drift (slugs, module
lists, patterns) are read from the library's own metadata, not hardcoded.
@bidzyyys
develop-secure-contracts: align Sui dep/docs paths with setup skill
04a2b7b 
Address PR review: make the Sui dependency-source and code-docs locations
precise and consistent with setup-sui-contracts — read exact signatures from
build/<pkg>/sources/dependencies/<move_package_name>/, and note dependency
docs land under build/<pkg>/docs/dependencies/<move_package_name>/.
@bidzyyys
develop-secure-contracts: generic --build-env; run the full quality g…
fec6d30 
…ate before finishing

- Use `--build-env <env>` (required whenever there are MVR deps) rather than
  enumerating `testnet|mainnet` (PR review).
- Note to run the project's full quality gate (build, test, prettier-move,
  lint) before finishing.
@bidzyyys
develop-secure-contracts: distinct dep/project placeholders; route fo…
129e331 
…rmatter to SSOT

Address PR review:
- Disambiguate `<pkg>`: use `<move_package_name>` for the Move.toml dependency
  key and `<project_package>` for the `build/.../` output directory.
- Quality-gate note no longer names a formatter; defer the exact commands and
  formatter to the setup-sui-contracts skill (single source of truth) instead
  of restating them.
bidzyyys added 2 commits July 15, 2026 11:47
@bidzyyys
develop-secure-contracts: reach the API reference via the catalog Doc…
bb7b33c 
…s link

Address PR review: drop the ambiguous `.../<major>.x/api/<package>` path
(the URL segment isn't the Move package name); route to the canonical API
reference through each package's catalog `Docs` link instead.
@bidzyyys
develop-secure-contracts: add Sui pattern-discovery test case (3.6)
2641623 
Fresh-subagent case: integrate OZ RBAC into an existing Sui Move module —
verifies discovery from library metadata/examples (no CLI generator), import
via MVR (not copy), and reading installed dependency source for signatures.
@bidzyyys
bidzyyys force-pushed the feat/develop-secure-sui branch from 8c42f12 to 2641623 Compare July 15, 2026 09:47
@bidzyyys
develop-secure-contracts: collapse the Sui section to a single llms.t…
13e86da 
…xt pointer

Addresses review feedback that the Sui-specific notes were too verbose for a
shared multi-ecosystem skill and polluted context for non-Sui readers. Replace
the "Sui Move Integration Notes" section and the grid paragraph with one concise
note that routes to llms.txt (the single entry point) + the setup-sui-contracts
skill, and trim the Step 1 dependency-location bullet to match its peers.
@bidzyyys
bidzyyys requested review from Copilot and ericglau July 15, 2026 10:13
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread skills/develop-secure-contracts/SKILL.md
Comment thread dev/TESTING.md Outdated
@bidzyyys
develop-secure-contracts: drop stray sui move build --doc from test…
7b02052 
… 3.6

The example omitted `--build-env`, which fails on MVR deps. The develop-secure
pattern-discovery path reads the installed source via the build mirror; the
`--doc` generation flow belongs to the setup-sui-contracts skill, so don't
duplicate it here.
@bidzyyys
bidzyyys requested a review from Copilot July 15, 2026 10:36
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread dev/TESTING.md Outdated
@bidzyyys
develop-secure-contracts: use MVR slug placeholder in test 3.6 setup
91654f5 
Genericize the concrete `@openzeppelin-move/access` slug to the
`@openzeppelin-move/<slug>` placeholder form used elsewhere in the skills, so
the scenario doesn't pin a specific registry slug that could drift.
@bidzyyys
bidzyyys requested a review from Copilot July 15, 2026 10:47
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread dev/TESTING.md
ericglau
ericglau approved these changes Jul 15, 2026
View reviewed changes

@ericglau ericglau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bidzyyys
bidzyyys merged commit cd1a4e0 into main Jul 15, 2026
3 checks passed
@bidzyyys
bidzyyys deleted the feat/develop-secure-sui branch July 15, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@0xNeshi 0xNeshi 0xNeshi approved these changes
@ericnordelo ericnordelo ericnordelo approved these changes
@ericglau ericglau ericglau approved these changes
@kosedogus kosedogus Awaiting requested review from kosedogus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

develop-secure-contracts: add Sui Move support

5 participants

@bidzyyys @0xNeshi @ericnordelo @ericglau