fix(export): add polkadot adapter to version registry and harden versioning pipeline (#353)

* fix(export): add polkadot adapter to version registry and harden versioning pipeline

Polkadot adapter was missing from versions.ts, update-export-versions
script, and CLI local overrides, causing production exports to emit
workspace:* which fails for end users. Staging worked by accident
because its fallback always outputs the 'rc' dist-tag.

Adds a defensive fallback in the production code path so unregistered
adapters resolve to 'latest' instead of leaking workspace:*. Introduces
VersioningSafetyGuard tests covering all four developed ecosystems, and
updates CI e2e matrix from [evm, solana, stellar] to
[evm, stellar, polkadot, midnight].

* fix(export): address PR review comments

Fix EXPORT_TEST_CHAIN → EXPORT_TEST_ECOSYSTEM env var mismatch in
export-app.cjs so the CI e2e matrix actually tests each chain instead
of always falling back to evm. Update CLI help text to list the
current supported ecosystems. Add a unit test verifying the workspace:*
→ latest production fallback.

* ci(export): limit e2e matrix to vitest-compatible ecosystems

Stellar and Midnight adapters have third-party dependencies with
ESM/CJS incompatibilities that prevent them from loading in the
Vitest runner. Restrict the CI e2e matrix to EVM and Polkadot.
Versioning correctness for all ecosystems is covered by
VersioningSafetyGuard.test.ts.

Author: pasevin

.github/workflows/export-testing.yml

@@ -105,7 +105,10 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        chain: [evm, solana, stellar]
+        # Stellar (@stellar/freighter-api CJS) and Midnight (@apollo/client ESM directory imports)
+        # have adapter deps incompatible with the Vitest ESM loader. Versioning correctness for
+        # all ecosystems is validated by VersioningSafetyGuard.test.ts (mock-based, no dynamic import).
+        chain: [evm, polkadot]
         node-version: [22.x]
 
     steps:

apps/builder/src/export/PackageManager.ts

@@ -532,7 +532,14 @@ export class PackageManager {
           }
         } else {
           // Production: Use stable published versions
-          if (managedVersion.startsWith('^') || managedVersion === 'workspace:*') {
+          if (managedVersion === 'workspace:*') {
+            logger.warn(
+              'PackageManager',
+              `Adapter package "${pkgName}" has no managed version in versions.ts. ` +
+                `Falling back to 'latest' dist-tag for production.`
+            );
+            updatedDependencies[pkgName] = 'latest';
+          } else if (managedVersion.startsWith('^')) {
             updatedDependencies[pkgName] = managedVersion;
           } else {
             updatedDependencies[pkgName] = `^${managedVersion}`;

apps/builder/src/export/__tests__/AdapterIntegrationTests.test.ts

@@ -1,37 +1,24 @@
 import { beforeEach, describe, expect, it } from 'vitest';
 
-import type { EvmNetworkConfig, NetworkConfig, SolanaNetworkConfig } from '@openzeppelin/ui-types';
+import type { Ecosystem, NetworkConfig } from '@openzeppelin/ui-types';
 
+import { adapterPackageMap, getNetworksByEcosystem } from '../../core/ecosystemManager';
 import { AppExportSystem } from '../AppExportSystem';
 import { createMinimalContractSchema, createMinimalFormConfig } from '../utils/testConfig';
 import { extractFilesFromZip } from '../utils/zipInspector';
 
-// Define mock network configs
-const mockEvmNetworkConfig: EvmNetworkConfig = {
-  id: 'test-export-adapter-evm',
-  name: 'Test Export EVM',
-  exportConstName: 'mockEvmNetworkConfig',
-  ecosystem: 'evm',
-  network: 'ethereum',
-  type: 'testnet',
-  isTestnet: true,
-  chainId: 1337,
-  rpcUrl: 'http://localhost:8545',
-  nativeCurrency: { name: 'TETH', symbol: 'TETH', decimals: 18 },
-  apiUrl: '',
-};
+// Stellar and Midnight adapters have ESM/CJS compatibility issues when loaded
+// dynamically in vitest. Full e2e export tests are limited to EVM and Polkadot.
+// Versioning correctness for ALL ecosystems is verified in VersioningSafetyGuard.test.ts.
+const EXPORTABLE_ECOSYSTEMS: Ecosystem[] = ['evm', 'polkadot'];
 
-const mockSolanaNetworkConfig: SolanaNetworkConfig = {
-  id: 'test-export-adapter-solana',
-  name: 'Test Export Solana',
-  exportConstName: 'mockSolanaNetworkConfig',
-  ecosystem: 'solana',
-  network: 'solana',
-  type: 'testnet',
-  isTestnet: true,
-  rpcEndpoint: 'mock',
-  commitment: 'confirmed',
-};
+async function getFirstNetwork(ecosystem: Ecosystem): Promise<NetworkConfig> {
+  const networks = await getNetworksByEcosystem(ecosystem);
+  if (networks.length === 0) {
+    throw new Error(`No networks found for ecosystem: ${ecosystem}`);
+  }
+  return networks[0];
+}
 
 describe('Adapter Integration Tests', () => {
   let exportSystem: AppExportSystem;
@@ -40,7 +27,6 @@ describe('Adapter Integration Tests', () => {
     exportSystem = new AppExportSystem();
   });
 
-  // Helper function to get exported files and parsed package.json
   async function getExportedPackageJson(
     networkConfig: NetworkConfig,
     functionName: string = 'transfer'
@@ -64,28 +50,36 @@ describe('Adapter Integration Tests', () => {
   }
 
   describe('Package.json Adapter Dependencies', () => {
-    it('should include correct dependencies for EVM in package.json', async () => {
-      const { packageJson } = await getExportedPackageJson(mockEvmNetworkConfig);
-
-      // Check required packages are present
-      expect(packageJson.dependencies).toHaveProperty('@openzeppelin/ui-types');
-      expect(packageJson.dependencies).toHaveProperty('@openzeppelin/ui-builder-adapter-evm');
-
-      // Optional: Check if specific SDKs (like ethers) are NOT directly listed if they are peer/sub-dependencies
-      // expect(packageJson.dependencies).not.toHaveProperty('ethers');
-    });
+    it.each(EXPORTABLE_ECOSYSTEMS)(
+      'should include correct adapter dependency for %s in package.json',
+      async (ecosystem) => {
+        const networkConfig = await getFirstNetwork(ecosystem);
+        const { packageJson } = await getExportedPackageJson(networkConfig);
+        const expectedAdapter = adapterPackageMap[ecosystem];
 
-    it('should include correct dependencies for Solana in package.json', async () => {
-      const { packageJson } = await getExportedPackageJson(mockSolanaNetworkConfig);
+        expect(packageJson.dependencies).toHaveProperty('@openzeppelin/ui-types');
+        expect(packageJson.dependencies).toHaveProperty(expectedAdapter);
+      }
+    );
 
-      // Check required packages are present
-      expect(packageJson.dependencies).toHaveProperty('@openzeppelin/ui-types');
-      expect(packageJson.dependencies).toHaveProperty('@openzeppelin/ui-builder-adapter-solana');
+    it.each(EXPORTABLE_ECOSYSTEMS)(
+      'should not include adapters from other ecosystems in %s export',
+      async (ecosystem) => {
+        const networkConfig = await getFirstNetwork(ecosystem);
+        const { packageJson } = await getExportedPackageJson(networkConfig);
+        const expectedAdapter = adapterPackageMap[ecosystem];
 
-      // Optional: Check specific SDKs are NOT directly listed
-      // expect(packageJson.dependencies).not.toHaveProperty('@solana/web3.js');
-    });
+        for (const [otherEcosystem, otherAdapter] of Object.entries(adapterPackageMap)) {
+          if (otherEcosystem !== ecosystem) {
+            expect(
+              packageJson.dependencies,
+              `${ecosystem} export should not contain adapter for ${otherEcosystem}`
+            ).not.toHaveProperty(otherAdapter);
+          }
+        }
 
-    // Add similar tests for Stellar and Midnight if needed
+        expect(packageJson.dependencies).toHaveProperty(expectedAdapter);
+      }
+    );
   });
 });