Update uart handling and version string Fixes #357

Author: georgevigelette

src/openlifu/io/LIFUHVController.py

@@ -133,8 +133,13 @@ def get_version(self) -> str:
             # r.print_packet()
             if r.data_len == 3:
                 ver = f"v{r.data[0]}.{r.data[1]}.{r.data[2]}"
-            else:
-                ver = "v0.0.0"
+            elif r.data_len and r.data:
+                try:
+                    # Decode only the valid length, strip trailing NULs and whitespace
+                    ver_str = r.data[:r.data_len].decode('utf-8', errors='ignore').rstrip('\x00').strip()
+                    ver = ver_str if ver_str else 'v0.0.0'
+                except Exception:
+                    ver = 'v0.0.0'
             logger.info(ver)
             return ver
 

src/openlifu/io/LIFUUart.py

@@ -228,7 +228,7 @@ def disconnect(self):
             return
 
         if self.read_thread:
-            self.read_thread.join()
+            self.read_thread.join(timeout=5)
         if self.serial and self.serial.is_open:
             self.serial.close()
             self.serial = None
@@ -367,8 +367,14 @@ def _read_data(self, timeout=20):
                 else:
                     time.sleep(0.05)  # Brief sleep to avoid a busy loop
             except serial.SerialException as e:
+                if "ClearCommError" in str(e):
+                    log.warning("Serial _read_data ClearCommError on %s (ignoring): %s", self.descriptor, e)
+                    time.sleep(0.1)
+                    continue
                 log.error("Serial _read_data error on %s: %s", self.descriptor, e)
                 self.running = False
+                self.signal_disconnect.emit(self.descriptor, self.port)
+                self.port = None
 
     def _tx(self, data: bytes):
         """Send data over UART."""