P/improve test watertank#352
Conversation
peterhollender
left a comment
peterhollender
left a comment
There was a problem hiding this comment.
Looks good. We'll want confirmation from @alkagan that no further changes are needed to support communication to the Slicer extension
There was a problem hiding this comment.
test_watertank was saving files to the root directory. Switched it to put them in a logs directory, so adding that to the .gitignore
There was a problem hiding this comment.
Adds new transducer definitions with the proper pin-mapping. We can skip this add update dvc in a separate PR if needed.
There was a problem hiding this comment.
We fixed up the way "mode" and "trigger_mode" were used across io. Now everything uses trigger_mode and it is converted to an integer at a low level
There was a problem hiding this comment.
Looks like the team added some extra scripts. I'll ultimately want to clean up notebooks, but its probably OK for the moment.
There was a problem hiding this comment.
This is the main test script we're using. It's been significantly improved.
There was a problem hiding this comment.
important changes to make sequencing work
| "TriggerPulseCount": pulse_count, | ||
| "TriggerPulseWidthUsec": pulse_width, | ||
| "TriggerPulseTrainInterval": pulse_train_interval, | ||
| "TriggerPulseTrainInterval": pulse_train_interval * 1000000, |
There was a problem hiding this comment.
In the long run, we should rename this to "TriggerPulseTrainIntervalUsec", but that will also require a firmware update. See #353
| if cycles > (MAX_REPEAT+1): | ||
| # Use elastic repeat | ||
| pulse_duration_samples = cycles * self.bf_clk / profile_index.frequency | ||
| pulse_duration_samples = self.bf_clk * ((cycles / profile_index.frequency) + ELASTIC_MODE_PULSE_LENGTH_ADJUST) |
There was a problem hiding this comment.
I hate magic numbers, so created #351 to investigate this further.
There was a problem hiding this comment.
Channel reversing is contained here.
There was a problem hiding this comment.
convenience functions
… setting solution.
…us() in LIFUInterface
import these from LIFUConfig
ebrahimebrahim
force-pushed
the
p/improve-test-watertank
branch
from
2e31095 to
f6ae4dd
Compare
3 participants
Makes changes to the
iomodule to improve communication with hardware.test_watertank.pyCloses #349
Closes #354