feat: Add mainlobe-to-sidelobe pressure and intensity ratios

[peterhollender]

Adds the calculation and reporting of mainlobe-to-sidelobe pressure and intensity ratios to the SolutionAnalysis.

• New fields in SolutionAnalysis dataclass.
• PARAM_FORMATS updated for table display.
• Ratio calculation logic added to Solution.analyze(), handling division by zero.
• Tests updated and new tests added for ratio calculations.

Closes #345

[peterhollender]

All the coding was done by Jules. I've verified that it works as expected.

[ebrahimebrahim]

Tested in SlicerOpenLIFU, no issues there

Looked over the test cases a bit to sanity check

Left a question below, if that seems fine let me know.

[ebrahimebrahim]

If we get nan's here, will ParameterConstraint checks fumble or will it know what to do?

From a cursory look, it looks like ParameterConstraint.compare doesn't check if something is nan
But any comparison against np.nan should be false, so maybe it's fine.

That's how we want it to behave right? If np.nan comes out for this ratio, parameter constraints will just fail and the solution cannot be approved.

[peterhollender]

Yeah, that makes sense as intended behavior.

…

On Thu, Jul 10, 2025 at 2:14 PM Ebrahim Ebrahim ***@***.***> wrote: ***@***.**** commented on this pull request. Tested in SlicerOpenLIFU, no issues there Looked over the test cases a bit to sanity check Left a question below, if that seems fine let me know. ------------------------------ In src/openlifu/plan/solution.py <#355 (comment)> : > @@ -250,8 +250,29 @@ def analyze(self, solution_analysis.mainlobe_isppa_Wcm2 += [float(ipa_Wcm2.where(mainlobe_mask).max())] solution_analysis.mainlobe_ispta_mWcm2 += [float(ita_mWcm2.where(mainlobe_mask).max())] - solution_analysis.sidelobe_pnp_MPa += [float(pnp_MPa.where(sidelobe_mask).max())] - solution_analysis.sidelobe_isppa_Wcm2 += [float(ipa_Wcm2.where(sidelobe_mask).max())] + + sidelobe_pnp = float(pnp_MPa.where(sidelobe_mask).max()) + sidelobe_isppa = float(ipa_Wcm2.where(sidelobe_mask).max()) + + solution_analysis.sidelobe_pnp_MPa += [sidelobe_pnp] + solution_analysis.sidelobe_isppa_Wcm2 += [sidelobe_isppa] + + # Calculate and store ratios (sidelobe / mainlobe) + mainlobe_pnp = solution_analysis.mainlobe_pnp_MPa[-1] + mainlobe_isppa = solution_analysis.mainlobe_isppa_Wcm2[-1] + + if mainlobe_pnp == 0: + pressure_ratio = np.inf if sidelobe_pnp != 0 else np.nan If we get nan's here, will ParameterConstraint checks fumble or will it know what to do? From a cursory look, it looks like ParameterConstraint.compare doesn't check if something is nan But any comparison against np.nan should be false, so maybe it's fine. That's how we want it to behave right? If np.nan comes out for this ratio, parameter constraints will just fail and the solution cannot be approved. — Reply to this email directly, view it on GitHub <#355 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPN2LLOKXDVYO3TUXX37I33H2UPLAVCNFSM6AAAAACAMO5LPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMBWG43TKNBZHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>