Skip to content

udpate api documentation#359

Merged
arhowe00 merged 4 commits into
mainfrom
api_documentation
Sep 8, 2025
Merged

udpate api documentation#359
arhowe00 merged 4 commits into
mainfrom
api_documentation

Conversation

@georgevigelette

Copy link
Copy Markdown
Contributor

Create Updated API documentation.

@peterhollender peterhollender requested a review from arhowe00 July 22, 2025 17:37

@arhowe00 arhowe00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to pass the review to @peterhollender on this one (with minor suggestions). Not going to be nit-picky about the API documentation of the hardware interface. We'll have to discover if anything needs to change with these docs when we have real plug and play with hardware.

One additional comment is whether it makes sense to duplicate documentation. If you can write sufficient docstrings in functions, lots of this formatted material can be made by auto docs generators, and it reduces the risk of forgetting to change things in multiple places. The "usage examples" may be useful being here, but I'd say lots of the text here could be specified elsewhere.

Comment thread docs/LIFU_Interface_api.md Outdated
Comment thread docs/hv_controller_api.md Outdated
Comment thread docs/tx_device_api.md
@peterhollender

Copy link
Copy Markdown
Contributor

Tagging @georgevigelette for when he has time to tidy these up

@ebrahimebrahim

Copy link
Copy Markdown
Collaborator
  • Rebase to main to fix the CI issues which are unrelated to this PR
  • @georgevigelette Are you done with the cleanups? Can @arhowe00 do a final review?

@georgevigelette

georgevigelette commented Sep 2, 2025 via email

Copy link
Copy Markdown
Contributor Author

@ebrahimebrahim

Copy link
Copy Markdown
Collaborator

Heads up rebasing this to incorporate fix to CI

@arhowe00 arhowe00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. The updates to the existing docs for HVController and TxDevice add useful details. I'll proceed with a squash-merge to make it a single commit.

@arhowe00 arhowe00 merged commit 4573b20 into main Sep 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants