Feature/protocol to table#361
Conversation
This commit introduces a `to_table` method to the `Protocol` class, which returns a Pandas DataFrame summarizing the protocol's parameters. This is useful for displaying protocol information in a structured format. - Added `to_table` method to `Protocol` class. - Added `get_table` methods to `FocalPattern`, `SimSetup`, `DelayMethod`, `ApodizationMethod`, and `SegmentationMethod` classes and their subclasses. - Added tests for the new `to_table` method. - Added an example of the table output to the `to_table` method's docstring.
The example output table was not accurate
arhowe00
left a comment
arhowe00
left a comment
There was a problem hiding this comment.
Approved for merging, but I left a question @peterhollender you should look at before doing so.
|
|
||
| :returns: Pandas DataFrame of the segmentation method parameters | ||
| """ | ||
| records = [{"Name": "Type", "Value": "Uniform Tissue", "Unit": ""}, |
There was a problem hiding this comment.
Why are we returning the reference material here but not for the UniformTissue/UniformWater? Also, are we sure that all UniformSegmentation are always "Uniform Tissue" Type?
There was a problem hiding this comment.
Good catch. We should be. Fixed.
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
Some commit messages do not follow the guidelines of referencing an issue number. Adding a "request changes" to block merging so that we remember to address this.
Awaiting peter's reply to andrew's review then if the commit messages are left as is we can just squash-n-merge
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
Looks good, thanks! Squashing and merging for this one
3 participants
Closes #360