Fix test scripts to call start_sonication() which now includes HV turn on command.#371
Conversation
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
LGTM; leaving final approval to Peter
|
(the commit message subject line is very long though. not too important but generally best to keep the subject (the first line) very short and add details if needed in the message body) |
alkagan
force-pushed
the
bugfix/scripts_turn_hv_on_through_start_sonication_function
branch
from
9ff05f0 to
bd0b31e
Compare
Modified commit message to be neater |
peterhollender
left a comment
peterhollender
left a comment
There was a problem hiding this comment.
@alkagan please open an issue to handle the technical debt incurred here. We've discussed a more robust "no power supply" state for the LIFUInterface that we should implement (as opposed to a kwarg in start_sonication directly), but we do need this hotfix pushed out now.
|
Rebasing and merging... |
…75) -Change all start_trigger() calls to start_sonication() calls in test scripts
ebrahimebrahim
force-pushed
the
bugfix/scripts_turn_hv_on_through_start_sonication_function
branch
from
bd0b31e to
84553e7
Compare
3 participants
Changed all start_trigger() calls to start_sonication() calls in test scripts, added function parameter to start_sonication() to select using external power supply. (#75)