Refactor Connection types with codegen#549
Merged
Merged
Conversation
rocktavious
commented
May 19, 2025
rocktavious
commented
May 19, 2025
rocktavious
commented
May 20, 2025
| client := BestTestClient(t, "rubric/level/list", testRequest) | ||
| // Act | ||
| result, _ := client.ListLevels() | ||
| result, err := client.ListLevels(nil) |
Contributor
Author
There was a problem hiding this comment.
This is the only customer facing change and since its a argument change in a type safe language customers code (or our other tools) will detect it at compile time
derek-etherton-opslevel
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #
Problem
The connection types in our API are not generated by client-gen and thus everything for them in opslevel-go is hand crafted.
Solution
Actually generate the most common connection types that use
nodes(for now excluding ones that truly need edges) and then fix up any none standard code because of this unificationAdditionally I took the time to bite off the change to stop using
totalCounteverywhere since its unreliable between different queries (especially ones with filtering on the "list" call) So this just calculates on the client side the final total based on the final length of the nodes array after all pagination (and nested pagination) is done.Checklist