Skip to content

Kr/relationship definitions pt2#550

Merged
rocktavious merged 5 commits into
mainfrom
kr/relationship-definitions-pt2
May 21, 2025
Merged

Kr/relationship definitions pt2#550
rocktavious merged 5 commits into
mainfrom
kr/relationship-definitions-pt2

Conversation

@rocktavious
Copy link
Copy Markdown
Contributor

Resolves #

Problem

There was no Get or List for relationship definition AND no tests for the entire CRUD functionality

Solution

Add Get and List and tests

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Does this change require a Terraform schema change?
    • If so what is the ticket or PR #
  • Make a changie entry that explains the customer facing outcome of this change

@rocktavious rocktavious requested a review from jasonopslevel May 20, 2025 16:37
@rocktavious rocktavious self-assigned this May 20, 2025
Copy link
Copy Markdown
Contributor

@jasonopslevel jasonopslevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rocktavious rocktavious changed the base branch from main to kr/code-gen-connections May 20, 2025 19:54
Copy link
Copy Markdown
Contributor

@jasonopslevel jasonopslevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM!

Base automatically changed from kr/code-gen-connections to main May 21, 2025 15:11
@rocktavious rocktavious force-pushed the kr/relationship-definitions-pt2 branch from c3d752c to dfb3305 Compare May 21, 2025 15:13
@rocktavious rocktavious merged commit d0530ea into main May 21, 2025
5 checks passed
@rocktavious rocktavious deleted the kr/relationship-definitions-pt2 branch May 21, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants