fix service LastDeploy field to not use pagination variables#553
Merged
Conversation
| if variables == nil { | ||
| variables = client.InitialPageVariablesPointer() | ||
| variables = &PayloadVariables{} | ||
| } |
Contributor
Author
There was a problem hiding this comment.
considered getting rid of the variables param altogether since this query will only really use serviceId, but figure keeping it is:
a. backwards compatible with current version of opslevel-mcp, and
b. more future-proof?
rocktavious
approved these changes
May 22, 2025
Contributor
rocktavious
left a comment
There was a problem hiding this comment.
I swear i tested this and it worked. 🤔 at any rate 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #
Problem
Fixes that we were defaulting
GetLastDeployparams to pagination params, when those aren't accepted for this (singular) field.Solution
Checklist