Skip to content

fix service LastDeploy field to not use pagination variables#553

Merged
derek-etherton-opslevel merged 1 commit into
mainfrom
fix-service-last-deploy
May 22, 2025
Merged

fix service LastDeploy field to not use pagination variables#553
derek-etherton-opslevel merged 1 commit into
mainfrom
fix-service-last-deploy

Conversation

@derek-etherton-opslevel
Copy link
Copy Markdown
Contributor

Resolves #

Problem

Fixes that we were defaulting GetLastDeploy params to pagination params, when those aren't accepted for this (singular) field.

Solution

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Does this change require a Terraform schema change?
    • If so what is the ticket or PR #
  • Make a changie entry that explains the customer facing outcome of this change

Comment thread service.go
if variables == nil {
variables = client.InitialPageVariablesPointer()
variables = &PayloadVariables{}
}
Copy link
Copy Markdown
Contributor Author

@derek-etherton-opslevel derek-etherton-opslevel May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considered getting rid of the variables param altogether since this query will only really use serviceId, but figure keeping it is:
a. backwards compatible with current version of opslevel-mcp, and
b. more future-proof?

Copy link
Copy Markdown
Contributor

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear i tested this and it worked. 🤔 at any rate 🚀

@derek-etherton-opslevel derek-etherton-opslevel merged commit 27f61cf into main May 22, 2025
5 checks passed
@derek-etherton-opslevel derek-etherton-opslevel deleted the fix-service-last-deploy branch May 22, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants