Skip to content

fix service LastDeploy field to not use pagination variables #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derek-etherton-opslevel merged 1 commit into from
May 22, 2025
Merged

fix service LastDeploy field to not use pagination variables #553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,9 @@ func (service *Service) GetLastDeploy(client *Client, variables *PayloadVariable
if service.Id == "" {
return nil, fmt.Errorf("unable to get LastDeploy, invalid service id: '%s'", service.Id)
}

if variables == nil {
variables = client.InitialPageVariablesPointer()
variables = &PayloadVariables{}
}
Copy link
Copy Markdown
Contributor Author

@derek-etherton-opslevel derek-etherton-opslevel May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considered getting rid of the variables param altogether since this query will only really use serviceId, but figure keeping it is:
a. backwards compatible with current version of opslevel-mcp, and
b. more future-proof?

(*variables)["service"] = service.Id
if err := client.Query(&q, *variables, WithName("ServiceLastDeploy")); err != nil {
Expand Down
Loading