Add the user name to the lightweight UserId struct#559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #
Problem
The CLI command
opslevel list team -o jsonoutputs amembershipssection that usesUserIdwhich currently only hasIdandEmailfor the user but a customer would like to also haveNamewhich is entirely reasonable.Solution
Move the
Namefield to theUserIdstruct fixes this and doesn't cause any "interface" changes to the end user just to the shape of the queries made - user name - should be lightweight enough and expected information when you are getting just theUserIdstruct back so this should be a 100% safe change.Checklist