Skip to content

Add the user name to the lightweight UserId struct#559

Merged
rocktavious merged 1 commit into
mainfrom
kr/fix-user-id
May 28, 2025
Merged

Add the user name to the lightweight UserId struct#559
rocktavious merged 1 commit into
mainfrom
kr/fix-user-id

Conversation

@rocktavious
Copy link
Copy Markdown
Contributor

Resolves #

Problem

The CLI command opslevel list team -o json outputs a memberships section that uses UserId which currently only has Id and Email for the user but a customer would like to also have Name which is entirely reasonable.

Solution

Move the Name field to the UserId struct fixes this and doesn't cause any "interface" changes to the end user just to the shape of the queries made - user name - should be lightweight enough and expected information when you are getting just the UserId struct back so this should be a 100% safe change.

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Does this change require a Terraform schema change?
    • If so what is the ticket or PR #
  • Make a changie entry that explains the customer facing outcome of this change

Copy link
Copy Markdown
Contributor

@derek-etherton-opslevel derek-etherton-opslevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocktavious rocktavious merged commit c54448c into main May 28, 2025
5 checks passed
@rocktavious rocktavious deleted the kr/fix-user-id branch May 28, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants