Skip to content

Commit 08c83bb

Browse files
authored
Mobkoi Adapter: bug: getUserSyncs no need to check gdprConsent (prebid#13599)
* getUserSyncs no need to check gdprConsent * removed invalid test * automatic cleanup event listener
1 parent 4a752c5 commit 08c83bb

3 files changed

Lines changed: 9 additions & 13 deletions

File tree

modules/mobkoiBidAdapter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,10 @@ export const spec = {
9191
return prebidBidResponse.bids;
9292
},
9393

94-
getUserSyncs: function(syncOptions, serverResponses, gdprConsent) {
94+
getUserSyncs: function(syncOptions, serverResponses) {
9595
const syncs = [];
9696

97-
if (!syncOptions.pixelEnabled || !gdprConsent.gdprApplies) {
97+
if (!syncOptions.pixelEnabled) {
9898
return syncs;
9999
}
100100

modules/mobkoiIdSystem.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,21 +105,25 @@ export const utils = {
105105
'&cookieName=sas_uid';
106106

107107
/**
108-
* Listen for messages from the iframe
108+
* Listen for messages from the iframe with automatic cleanup
109109
*/
110-
window.addEventListener('message', function(event) {
110+
const messageHandler = function(event) {
111111
switch (event.data.type) {
112112
case 'MOBKOI_PIXEL_SYNC_COMPLETE':
113113
const sasUid = event.data.syncData;
114114
logInfo('Parent window Sync completed. SAS ID:', sasUid);
115+
window.removeEventListener('message', messageHandler);
115116
onCompleteCallback(sasUid);
116117
break;
117118
case 'MOBKOI_PIXEL_SYNC_ERROR':
118119
logError('Parent window Sync failed:', event.data.error);
120+
window.removeEventListener('message', messageHandler);
119121
onCompleteCallback(null);
120122
break;
121123
}
122-
});
124+
};
125+
126+
window.addEventListener('message', messageHandler);
123127

124128
insertUserSyncIframe(url, () => {
125129
logInfo('insertUserSyncIframe loaded');

test/spec/modules/mobkoiBidAdapter_spec.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -259,14 +259,6 @@ describe('Mobkoi bidding Adapter', function () {
259259
expect(result).to.be.an('array').that.is.empty;
260260
});
261261

262-
it('should return empty array when GDPR does not apply', function () {
263-
const gdprConsent = { gdprApplies: false, consentString: 'test-consent' };
264-
const serverResponses = [{ body: { ext: { pixels: [['image', 'test-url']] } } }];
265-
266-
const result = spec.getUserSyncs(syncOptions, serverResponses, gdprConsent);
267-
expect(result).to.be.an('array').that.is.empty;
268-
});
269-
270262
it('should return empty array when no pixels in response', function () {
271263
const gdprConsent = { gdprApplies: true, consentString: 'test-consent' };
272264
const serverResponses = [{ body: { ext: {} } }];

0 commit comments

Comments
 (0)