-
Notifications
You must be signed in to change notification settings - Fork 59
[OUDS] Add sprite to Stackblitz example to have icons #3464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hannahiss
wants to merge
11
commits into
ouds/main
Choose a base branch
from
ouds/main-his-svg-stackblitz
base: ouds/main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e597e1b
Add sprite to Stackblitz example to have icons
hannahiss a1d90c9
try another way for svg
hannahiss 5ae8840
.
hannahiss 0cdd863
Merge branch 'ouds/main' into ouds/main-his-svg-stackblitz
hannahiss 9a27636
Merge branch 'ouds/main' into ouds/main-his-svg-stackblitz
hannahiss 561fd6c
Merge branch 'ouds/main' into ouds/main-his-svg-stackblitz
hannahiss 1b66819
Merge branch 'ouds/main' into ouds/main-his-svg-stackblitz
hannahiss 0b3bef2
Merge branch 'ouds/main' into ouds/main-his-svg-stackblitz
hannahiss 763049a
Update site/src/assets/stackblitz.js
hannahiss 0e1ebdd
Merge branch 'ouds/main' into ouds/main-his-svg-stackblitz
hannahiss 6b7fe5c
Merge branch 'ouds/main' into ouds/main-his-svg-stackblitz
hannahiss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -20,7 +20,8 @@ const CONFIG = { | |||||
| cssCdn: '__CSS_CDN__', | ||||||
| cssBootstrapCdn: '__CSS_BOOTSTRAP_CDN__', | ||||||
| jsBundleCdn: '__JS_BUNDLE_CDN__', | ||||||
| docsVersion: '__DOCS_VERSION__' | ||||||
| docsVersion: '__DOCS_VERSION__', | ||||||
| brand: '__BRAND__' | ||||||
| } | ||||||
|
|
||||||
| // Open in StackBlitz logic | ||||||
|
|
@@ -40,19 +41,21 @@ document.querySelectorAll('.btn-edit').forEach(btn => { | |||||
| }) | ||||||
|
|
||||||
| const openOUDSWebSnippet = (htmlSnippet, jsSnippet, classes, cssBootstrap) => { | ||||||
| const spriteUrl = `https://web.unified-design-system.orange.com/${CONFIG.brand}/docs/${CONFIG.docsVersion}/assets/img/ouds-web-sprite.svg` | ||||||
| const indexHtml = `<!doctype html> | ||||||
| <html lang="en"> | ||||||
| <head> | ||||||
| <meta charset="utf-8"> | ||||||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||||||
| <link href="${cssBootstrap ? CONFIG.cssBootstrapCdn : CONFIG.cssCdn}" rel="stylesheet" /> | ||||||
| <link href="https://web.unified-design-system.orange.com/docs/${CONFIG.docsVersion}/assets/css/docs.css" rel="stylesheet" /> | ||||||
| <link rel="preload" href="${spriteUrl}" as="image" type="image/svg+xml" crossorigin="anonymous"> | ||||||
| <title>OUDS Web Example</title> | ||||||
| <${'script'} defer src="${CONFIG.jsBundleCdn}"></${'script'}> | ||||||
| </head> | ||||||
| <body class="p-2xlarge m-none border-none ${classes}"> | ||||||
| <!-- Example Code --> | ||||||
| ${htmlSnippet.trimStart().replace(/^/gm, ' ').replace(/^ {4}$/gm, '').trimEnd()} | ||||||
| ${htmlSnippet.trimStart().replace(/^/gm, ' ').replace(/^ {4}$/gm, '').replaceAll(/xlink:href="\/.+\/ouds-web-sprite\.svg/g, `xlink:href="${spriteUrl}`).trimEnd()} | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| <!-- End Example Code --> | ||||||
| </body> | ||||||
| </html>` | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we don't need BRAND