Skip to content

chore: switch to packmind#3496

Open
vprothais wants to merge 20 commits into
ouds/mainfrom
ouds/main-vp-packmind
Open

chore: switch to packmind#3496
vprothais wants to merge 20 commits into
ouds/mainfrom
ouds/main-vp-packmind

Conversation

@vprothais

@vprothais vprothais commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

Click the Preview tab and select a PR template:

Copilot AI review requested due to automatic review settings April 7, 2026 08:45
@boosted-bot boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 7, 2026
@netlify

netlify Bot commented Apr 7, 2026

Copy link
Copy Markdown

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit f2175ce
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/6a16c57e4d684300083fefe8
😎 Deploy Preview https://deploy-preview-3496--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces Packmind playbook artifacts (standards/commands/skills) and wires them into GitHub Copilot instructions to codify OUDS Web conventions (tokens, component patterns, accessibility, and workflows).

Changes:

  • Add OUDS-specific Packmind standards for tokens, component patterns, code conventions, and WCAG accessibility.
  • Add OUDS-specific Packmind commands for token validation, decision routing, error diagnosis, lookup, and component creation.
  • Add Packmind skill packages (including a playbook update workflow) plus a unified .github/copilot-instructions.md entrypoint.

Reviewed changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.packmind/standards/ouds-design-tokens.md Document token-layer usage rules
.packmind/standards/ouds-component-patterns.md Define SCSS/JS component patterns
.packmind/standards/ouds-code-conventions.md Define HTML/SCSS/JS conventions
.packmind/standards/ouds-accessibility-wcag.md Document WCAG 2.1 AA requirements
.packmind/skills/ouds-token-strategy.md Explain token architecture & dark mode
.packmind/skills/ouds-multi-brand-sync.md Explain multi-brand structure & workflow
.packmind/skills/ouds-knowledge-base.md Provide glossary + build/CI reference
.packmind/commands/ouds-validate-tokens.md Add token audit workflow
.packmind/commands/ouds-lookup.md Add quick routing index
.packmind/commands/ouds-diagnose-error.md Add lint/build/test diagnosis workflow
.packmind/commands/ouds-decision-routing.md Add decision trees for common tasks
.packmind/commands/ouds-create-component.md Add end-to-end component creation workflow
.github/skills/packmind-update-playbook/SKILL.md Define Packmind playbook update workflow
.github/skills/packmind-update-playbook/references/domain-standards.md Standards analysis reference
.github/skills/packmind-update-playbook/references/domain-skills.md Skills analysis reference
.github/skills/packmind-update-playbook/references/domain-commands.md Commands analysis reference
.github/skills/packmind-update-playbook/references/agent-skills-specification.md Agent skills format reference
.github/skills/packmind-update-playbook/LICENSE.txt License for update-playbook skill
.github/skills/packmind-onboard/README.md Onboarding skill README
.github/skills/packmind-onboard/LICENSE.txt License for onboard skill
.github/skills/packmind-onboard/references/test-data-construction.md Onboard reference: test data patterns
.github/skills/packmind-onboard/references/role-taxonomy-drift.md Onboard reference: role drift analysis
.github/skills/packmind-onboard/references/file-template-consistency.md Onboard reference: template detection
.github/skills/packmind-onboard/references/ci-local-workflow-parity.md Onboard reference: CI/local parity
.github/skills/packmind-create-standard/SKILL.md Skill: create standards via CLI
.github/skills/packmind-create-standard/README.md README for create-standard skill
.github/skills/packmind-create-standard/LICENSE.txt License for create-standard skill
.github/skills/packmind-create-skill/SKILL.md Skill: create skills + prerequisites
.github/skills/packmind-create-skill/scripts/quick_validate.py Script: validate skill structure
.github/skills/packmind-create-skill/scripts/init_skill.py Script: scaffold new skill
.github/skills/packmind-create-skill/README.md README for create-skill skill
.github/skills/packmind-create-skill/LICENSE.txt License for create-skill skill
.github/skills/packmind-create-package/SKILL.md Skill: create packages via CLI
.github/skills/packmind-create-package/README.md README for create-package skill
.github/skills/packmind-create-package/LICENSE.txt License for create-package skill
.github/skills/packmind-create-command/SKILL.md Skill: create commands via CLI
.github/skills/packmind-create-command/README.md README for create-command skill
.github/skills/packmind-create-command/LICENSE.txt License for create-command skill
.github/skills/packmind-cli-list-commands/SKILL.md Skill: list Packmind artifacts via CLI
.github/skills/packmind-cli-list-commands/README.md README for CLI list-commands skill
.github/skills/packmind-cli-list-commands/LICENSE.txt License for CLI list-commands skill
.github/copilot-instructions.md Aggregate OUDS Packmind guidance for Copilot

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Commands are reusable multi-step workflows distributed to AI coding agents. Each command has a name, summary, "when to use" list, context validation checkpoints, and numbered steps. Source files live in `**/.packmind/commands/<slug>.md`. Installed copies also exist in agent directories:
- Claude Code: `**/.claude/commands/`
- Cursor: `**/.cursor/commands/`
- GitHub Copilot: `**/.github/prompt/`

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installed-copy path for GitHub Copilot commands is inconsistent with the rest of this playbook (.github/prompts/ is used elsewhere) and looks like a typo (prompt vs prompts). Please align this path (and any other references) so the workflow points to the correct directory.

Suggested change
- GitHub Copilot: `**/.github/prompt/`
- GitHub Copilot: `**/.github/prompts/`

Copilot uses AI. Check for mistakes.
Comment on lines +37 to +40
### Use CSS custom properties for all color values — enables dark mode

Color tokens come in light/dark pairs (`$ouds-color-action-enabled-light` / `$ouds-color-action-enabled-dark`). These are exposed as CSS custom properties. Always use `var(--#{$prefix}color-*)` to enable runtime color-mode switching.

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule mandates using var(--#{$prefix}color-*) for all color values, but the codebase frequently uses $ouds-color-* variables (which are already redefined to var(--#{$prefix}...) in packages/*/scss/tokens/_semantic-colors-custom-props.scss). As written, this standard conflicts with existing component patterns and may cause confusing guidance. Consider updating the wording to forbid only the *-light/*-dark SCSS variables, and allow either var(--#{$prefix}color-*) or $ouds-color-* (post-bridge) as equivalent dark-mode-safe choices.

Copilot uses AI. Check for mistakes.
Comment on lines +70 to +73
### SCSS: always use OUDS design tokens — never hardcode values

Never hardcode colors, dimensions, or spacing. Use semantic tokens for spacing, CSS custom properties for colors, and component tokens for component-specific values.

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section implies colors must be referenced via var(--#{$prefix}color-*), but existing SCSS commonly uses $ouds-color-* (which already resolves to var(...) via the semantic-colors custom-props bridge). Consider clarifying that $ouds-color-* is also acceptable, and only the *-light/*-dark variables are forbidden in components.

Copilot uses AI. Check for mistakes.
Comment on lines +38 to +46
# Extract name for validation
name_match = re.search(r'name:\s*(.+)', frontmatter)
if name_match:
name = name_match.group(1).strip()
# Check naming convention (hyphen-case: lowercase with hyphens)
if not re.match(r'^[a-z0-9-]+$', name):
return False, f"Name '{name}' should be hyphen-case (lowercase letters, digits, and hyphens only)"
if name.startswith('-') or name.endswith('-') or '--' in name:
return False, f"Name '{name}' cannot start/end with hyphen or contain consecutive hyphens"

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick_validate.py extracts name: with a regex and then validates it against ^[a-z0-9-]+$, which will fail for valid YAML like name: 'packmind-create-skill' (quotes included). Either parse YAML properly or strip surrounding quotes before applying the regex, otherwise this validator will reject the skills in this repo.

Copilot uses AI. Check for mistakes.
@vprothais vprothais force-pushed the ouds/main-vp-packmind branch from f7014e3 to f2175ce Compare May 27, 2026 10:20
@louismaximepiton

Copy link
Copy Markdown
Member

Is there any way to embed a Skill to help us build the documentation following the documentation structure and based on already existing files ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Need Dev Review

Development

Successfully merging this pull request may close these issues.

[OUDS] Add an agents.md file to help users agents to understand our library

4 participants