Skip to content

feat(lib): Change PopperJs to Floating UI #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
louismaximepiton wants to merge 7 commits into
base: ouds/main-lmp-remove-jquery
Choose a base branch
from
Open

feat(lib): Change PopperJs to Floating UI #3502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f36d70
feat(lib): Change PopperJs to Floating UI
louismaximepiton Apr 8, 2026
e38fd88
Add migration guides
louismaximepiton Apr 8, 2026
0d41e3f
.
louismaximepiton Apr 8, 2026
fb054a6
fix ci
louismaximepiton Apr 8, 2026
3a9ed5b
fix issue in doc
louismaximepiton Apr 8, 2026
fc74831
fix copilot
louismaximepiton Apr 8, 2026
a1ef2e9
fix ci
louismaximepiton Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .bundlewatch.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,27 +42,27 @@
},
{
"path": "./dist/js/ouds-web.bundle.js",
"maxSize": "44.25 kB"
"maxSize": "46 kB"
},
{
"path": "./dist/js/ouds-web.bundle.min.js",
"maxSize": "24 kB"
},
{
"path": "./dist/js/ouds-web.esm.js",
"maxSize": "29.25 kB"
"maxSize": "32.25 kB"
},
{
"path": "./dist/js/ouds-web.esm.min.js",
"maxSize": "19 kB"
"maxSize": "20 kB"
},
{
"path": "./dist/js/ouds-web.js",
"maxSize": "30 kB"
"maxSize": "32.75 kB"
},
{
"path": "./dist/js/ouds-web.min.js",
"maxSize": "17 kB"
"maxSize": "17.75 kB"
}
],
"ci": {
Expand Down
1 change: 0 additions & 1 deletion .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ updates:
- dependency-name: "@babel/core"
- dependency-name: "@babel/preset-env"
- dependency-name: "@docsearch/js"
Comment thread
louismaximepiton marked this conversation as resolved.
- dependency-name: "@popperjs/core"
- dependency-name: "@rollup/plugin-babel"
- dependency-name: "@rollup/plugin-commonjs"
- dependency-name: "@rollup/plugin-node-resolve"
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ Within the download you’ll find the following directories and files, logically
```
</details>

We provide compiled CSS and JS (`ouds-web.*`), as well as compiled and minified CSS and JS (`ouds-web.min.*`). [Source maps](https://web.dev/articles/source-maps) (`ouds-web.*.map`) are available for use with certain browsers’ developer tools. Bundled JS files (`ouds-web.bundle.js` and minified `ouds-web.bundle.min.js`) include [Popper](https://popper.js.org/docs/v2/).
We provide compiled CSS and JS (`ouds-web.*`), as well as compiled and minified CSS and JS (`ouds-web.min.*`). [Source maps](https://web.dev/articles/source-maps) (`ouds-web.*.map`) are available for use with certain browsers’ developer tools. Bundled JS files (`ouds-web.bundle.js` and minified `ouds-web.bundle.min.js`) include [Floating UI](https://floating-ui.com/).

We also provide a compiled and minified CSS (`ouds-web-bootstrap.*` and `ouds-web-bootstrap.min.*`) enforcing Bootstrap compatibility.

Expand Down
4 changes: 2 additions & 2 deletions build/generate-sri.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ for (const brand of BRANDS) {
configPropertyName: 'js_bundle_hash'
},
{
file: 'node_modules/@popperjs/core/dist/umd/popper.min.js',
configPropertyName: 'popper_hash'
file: 'node_modules/@floating-ui/dom/dist/floating-ui.dom.umd.min.js',
configPropertyName: 'floating_ui_hash'
}
]

Expand Down
8 changes: 4 additions & 4 deletions build/rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const BUNDLE = process.env.BUNDLE === 'true'
const ESM = process.env.ESM === 'true'

let destinationFile = `ouds-web${ESM ? '.esm' : ''}`
const external = ['@popperjs/core']
const external = ['@floating-ui/dom']
const plugins = [
babel({
// Only transpile our source code
Expand All @@ -22,14 +22,14 @@ const plugins = [
})
]
const globals = {
'@popperjs/core': 'Popper'
'@floating-ui/dom': 'FloatingUIDOM'
}

if (BUNDLE) {
destinationFile += '.bundle'
// Remove last entry in external array to bundle Popper
// Remove last entry in external array to bundle Floating UI
external.pop()
delete globals['@popperjs/core']
delete globals['@floating-ui/dom']
plugins.push(
replace({
'process.env.NODE_ENV': '"production"',
Expand Down
Loading
Loading