feat(lib): Remove useless mixin rfs and font-size + remove vendor by louismaximepiton · Pull Request #3504 · Orange-OpenSource/Orange-Boosted-Bootstrap

louismaximepiton · 2026-04-09T12:31:01Z

Types of change

Non-breaking change
Breaking change (fix or feature that would change existing functionality and usage)

Related issues

Following twbs/bootstrap#41938.

Context & Motivation

Reduce our bundle size on CSS and remove dead code.

Description

Removes the rfs mixins and functions, as well as the font-size mixin.

Checklists

Checklist (for Core Team only)

The changes need to be in the migration guide
The changes are well displayed in Storybook (be careful if example order has changed for DSM)
The changes are compatible with RTL
Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Code review
Design review
A11y review
Commit on ouds/main following conventional commit

Live previews

https://deploy-preview-3504--boosted.netlify.app/

netlify · 2026-04-09T12:32:28Z

✅ Deploy Preview for boosted ready!

Name	Link
🔨 Latest commit	`38becd8`
🔍 Latest deploy log	https://app.netlify.com/projects/boosted/deploys/69e0acf4e84c7600087c41a4
😎 Deploy Preview	https://deploy-preview-3504--boosted.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR removes the RFS vendor implementation and related Sass mixins (rfs, font-size) across the SCSS codebase to reduce CSS bundle size, and updates the site/config/docs accordingly.

Changes:

Remove the RFS vendor file and all remaining @include rfs(...) / @include font-size(...) usages, replacing them with direct font-size: / CSS variable assignments.
Simplify utilities generation by dropping the RFS-specific branch and its tests.
Remove rfs_version from site config validation and from brand config files; update docs/migration notes to reflect the breaking change.

Reviewed changes

Copilot reviewed 39 out of 40 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
site/src/scss/_component-examples.scss	Replace `@include font-size(inherit)` with `font-size: inherit`.
site/src/libs/validation.ts	Remove `zPrefixedVersionSemver` validator (no longer needed).
site/src/libs/config.ts	Drop `rfs_version` from config schema/imports.
site/src/content/docs/utilities/api.mdx	Remove the (commented) `rfs` utility option row.
site/src/content/docs/getting-started/migration.mdx	Add migration notes about RFS/vendor and `font-size()` removal.
site/src/content/docs/getting-started/migration-from-boosted.mdx	Add similar migration notes for Boosted migrations.
site/src/content/docs/foundation/options.mdx	Remove `$enable-rfs` mention from options table.
scss/vendor/_rfs.scss	Delete the embedded RFS implementation.
scss/utilities/_api.scss	Remove the RFS rescaling media-query generation block.
scss/tests/mixins/_utilities.test.scss	Remove RFS-related `generate-utility` tests.
scss/mixins/_utilities.scss	Remove `$is-rfs-media-query` arg + RFS value selection logic.
scss/mixins/_pagination.scss	Replace `@include rfs(..., --var)` with direct CSS var assignment.
scss/mixins/_forms.scss	Replace `@include font-size(...)` with `font-size:`.
scss/mixins/_buttons.scss	Replace `@include rfs(..., --var)` with direct CSS var assignment.
scss/forms/_labels.scss	Replace `@include font-size(...)` with `font-size:`.
scss/forms/_input-group.scss	Replace `@include font-size(...)` with `font-size:`.
scss/forms/_form-text.scss	Update comment to reflect direct `font-size` replacement context.
scss/forms/_form-control.scss	Replace `@include font-size(...)` with `font-size:`.
scss/_variables.scss	Remove `$enable-rfs` variable.
scss/_type.scss	Update comments to reflect direct `font-size` replacement.
scss/_tooltip.scss	Replace RFS/css mixin usage with direct var assignment + `font-size:`.
scss/_toasts.scss	Replace RFS/css mixin usage with direct var assignment + `font-size:`.
scss/_root.scss	Replace `@include rfs(..., --body-font-size)` with direct CSS var assignment.
scss/_reboot.scss	Replace `@include font-size(...)` with `font-size:` in reboot rules.
scss/_progress.scss	Replace RFS/css mixin usage with direct var assignment + `font-size:`.
scss/_popover.scss	Replace RFS/css mixin usage with direct var assignment + `font-size:`.
scss/_pagination.scss	Replace RFS/css mixin usage with direct var assignment + `font-size:`.
scss/_navbar.scss	Replace RFS/css mixin usage with direct var assignment + `font-size:`.
scss/_nav.scss	Replace RFS/css mixin usage with direct var assignment + `font-size:`.
scss/_mixins.scss	Stop importing vendor RFS.
scss/_images.scss	Replace `@include font-size(...)` with `font-size:`.
scss/_dropdown.scss	Replace RFS/css mixin usage with direct var assignment + `font-size:`.
scss/_buttons.scss	Update comment reflecting removal of `--btn-font-size` handling.
scss/_accordion.scss	Replace `@include font-size(...)` with `font-size:`.
packages/sosh/scss/ouds-web-grid.scss	Remove `@import "@ouds/web-common/scss/vendor/rfs"`.
packages/sosh/config.yml	Remove `rfs_version` entry.
packages/orange/scss/ouds-web-grid.scss	Remove `@import "@ouds/web-common/scss/vendor/rfs"`.
packages/orange/config.yml	Remove `rfs_version` entry.
packages/orange-compact/scss/ouds-web-grid.scss	Remove `@import "@ouds/web-common/scss/vendor/rfs"`.
packages/orange-compact/config.yml	Remove `rfs_version` entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MaxLardenois

Just some small things

MaxLardenois · 2026-04-22T13:55:30Z

 h1 {
  @extend %heading;
-  @include get-font-size("heading-xlarge"); // OUDS mod: instead of `@include font-size($h1-font-size)`
+  @include get-font-size("heading-xlarge"); // OUDS mod: instead of `font-size: $h1-font-size`


Question: do you consider those "instead of" to be agains Boosted, Bootstrap or Bootstrap v6 ? For Boosted or Bootstrap it should still say "instead of @include font-size() no?

MaxLardenois · 2026-04-22T13:59:03Z


 - <span class="tag tag-small rounded-none tag-warning">Warning</span> `scss/mixins/_alert.scss` doesn’t exist anymore. If you were importing it in your project, please make sure to remove it.

+- <span class="tag tag-small rounded-none tag-warning">Warning</span> `scss/vendor/_rfs.scss` doesn’t exist anymore. You shouldn’t have used it anyway, but we removed it.


A little less passive aggressive ;)

Suggested change

- Warning `scss/vendor/_rfs.scss` doesn’t exist anymore. You shouldn’t have used it anyway, but we removed it.

- Warning `scss/vendor/_rfs.scss` has been removed. It was deprecated and should not have been used.

MaxLardenois · 2026-04-22T13:59:27Z


+- <span class="tag tag-small rounded-none tag-warning">Warning</span> `scss/vendor/_rfs.scss` doesn’t exist anymore. You shouldn’t have used it anyway, but we removed it.
+
+- <span class="tag tag-small rounded-none tag-negative">Breaking</span> `font-size()` mixin doesn’t exist anymore. You should refer to `get-font-size()` mixin instead.


Suggested change

- Breaking `font-size()` mixin doesn’t exist anymore. You should refer to `get-font-size()` mixin instead.

- Breaking `font-size()` mixin has been removed. Please refer to `get-font-size()` mixin instead.

MaxLardenois · 2026-04-22T14:00:21Z

+
+- <span class="tag tag-small rounded-none tag-warning">Warning</span> `scss/vendor/_rfs.scss` doesn’t exist anymore. You shouldn’t have used it anyway, but we removed it.
+
+- <span class="tag tag-small rounded-none tag-warning">Warning</span> `font-size()` mixin doesn’t exist anymore. You should refer to `get-font-size()` mixin instead.


Suggested change

- Warning `font-size()` mixin doesn’t exist anymore. You should refer to `get-font-size()` mixin instead.

- Warning `font-size()` mixin has been removed. Please refer to `get-font-size()` mixin instead.

MaxLardenois · 2026-04-22T14:00:59Z


+### CSS and Sass variables
+
+- <span class="tag tag-small rounded-none tag-warning">Warning</span> `scss/vendor/_rfs.scss` doesn’t exist anymore. You shouldn’t have used it anyway, but we removed it.


Suggested change

- Warning `scss/vendor/_rfs.scss` doesn’t exist anymore. You shouldn’t have used it anyway, but we removed it.

- Warning `scss/vendor/_rfs.scss` has been removed. It was deprecated and should not have been used.

feat(lib): Remove useless mixin rfs and font-size + remove vendor

7b82c3f

louismaximepiton added ⛓️‍💥 breaking change performance css 🧰 library labels Apr 9, 2026

github-project-automation Bot added this to 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 9, 2026

github-project-automation Bot moved this to In Progress / Draft in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 9, 2026

fix ci + migrations

cba159f

louismaximepiton marked this pull request as ready for review April 9, 2026 13:43

Copilot AI review requested due to automatic review settings April 9, 2026 13:43

boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 9, 2026

Copilot started reviewing on behalf of louismaximepiton April 9, 2026 13:44 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

fix review copilot

38becd8

MaxLardenois mentioned this pull request Apr 21, 2026

feat(lib): migrate breakpoints from infix to prefix #3499

Draft

21 tasks

MaxLardenois requested changes Apr 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lib): Remove useless mixin rfs and font-size + remove vendor#3504

feat(lib): Remove useless mixin rfs and font-size + remove vendor#3504
louismaximepiton wants to merge 3 commits intoouds/mainfrom
ouds/main-lmp-remove-rfs

louismaximepiton commented Apr 9, 2026 •

edited by boosted-bot

Loading

Uh oh!

netlify Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaxLardenois left a comment

Uh oh!

MaxLardenois Apr 22, 2026

Uh oh!

MaxLardenois Apr 22, 2026

Uh oh!

MaxLardenois Apr 22, 2026

Uh oh!

MaxLardenois Apr 22, 2026

Uh oh!

MaxLardenois Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		- <span class="tag tag-small rounded-none tag-warning">Warning</span> `scss/mixins/_alert.scss` doesn’t exist anymore. If you were importing it in your project, please make sure to remove it.

		- <span class="tag tag-small rounded-none tag-warning">Warning</span> `scss/vendor/_rfs.scss` doesn’t exist anymore. You shouldn’t have used it anyway, but we removed it.


		### CSS and Sass variables

		- <span class="tag tag-small rounded-none tag-warning">Warning</span> `scss/vendor/_rfs.scss` doesn’t exist anymore. You shouldn’t have used it anyway, but we removed it.

Conversation

louismaximepiton commented Apr 9, 2026 • edited by boosted-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of change

Related issues

Context & Motivation

Description

Checklists

Checklist (for Core Team only)

Progression (for Core Team only)

Live previews

Uh oh!

netlify Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for boosted ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaxLardenois left a comment

Choose a reason for hiding this comment

Uh oh!

MaxLardenois Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

MaxLardenois Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

MaxLardenois Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

MaxLardenois Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

MaxLardenois Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

louismaximepiton commented Apr 9, 2026 •

edited by boosted-bot

Loading

netlify Bot commented Apr 9, 2026 •

edited

Loading