feat: add ouds/web-migrate package by MaxLardenois · Pull Request #3523 · Orange-OpenSource/Orange-Boosted-Bootstrap

MaxLardenois · 2026-04-17T14:01:42Z

Types of change

Non-breaking change
Breaking change (fix or feature that would change existing functionality and usage)

Related issues

Closes #3520

Context & Motivation

Integrate the migration tool into OUDS web monorepo

Description

See packges/migrate/README.md

Checklists

Checklist (for Core Team only)

The changes need to be in the migration guide
The changes are well displayed in Storybook (be careful if example order has changed for DSM)
The changes are compatible with RTL
Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Code review
Design review
A11y review
Commit on ouds/main following conventional commit

Live previews

https://deploy-preview-3523--boosted.netlify.app/

netlify · 2026-04-17T14:03:13Z

✅ Deploy Preview for boosted ready!

Name	Link
🔨 Latest commit	`232d175`
🔍 Latest deploy log	https://app.netlify.com/projects/boosted/deploys/69eb81892bf9c90008442407
😎 Deploy Preview	https://deploy-preview-3523--boosted.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…-the-monorepo

Copilot

Pull request overview

Adds a new workspace package @ouds/web-migrate to integrate the OUDS Web migration CLI into the monorepo (issue #3520), including replacement rules and snapshot-based tests for HTML/CSS migrations.

Changes:

Introduces packages/migrate CLI package with migration engine (replace-in-file) and replacement sets for boosted, ob1, and ouds.
Adds Vitest tests + fixtures/snapshots covering replacements and warning emission.
Updates repo tooling to exclude the new non-brand workspace from SRI generation and links the workspace in the root lockfile.

Reviewed changes

Copilot reviewed 23 out of 26 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
packages/migrate/vitest.config.js	Adds Vitest configuration for the migrate package.
packages/migrate/tests/source-ouds.html	HTML fixture for “from ouds” migration testing.
packages/migrate/tests/source-ob1.html	HTML fixture for “from ob1” migration testing.
packages/migrate/tests/source-boosted.html	HTML fixture for “from boosted” migration testing.
packages/migrate/tests/source-boosted.css	CSS fixture for migration testing.
packages/migrate/tests/snapshots/migrated-ouds.html	Expected migrated output snapshot (ouds).
packages/migrate/tests/snapshots/migrated-ob1.html	Expected migrated output snapshot (ob1).
packages/migrate/tests/snapshots/migrated-boosted.html	Expected migrated output snapshot (boosted).
packages/migrate/tests/snapshots/migrated-boosted.css	Expected migrated output snapshot (CSS).
packages/migrate/src/utils/warnings.mjs	Warning collection + helpers for deprecated/removed classes.
packages/migrate/src/utils/args.mjs	CLI arg parsing for `--from`.
packages/migrate/src/replacements/replacements.spec.mjs	Unit tests for core replacement generators.
packages/migrate/src/replacements/ouds.mjs	OUDS breakpoint-related replacements.
packages/migrate/src/replacements/ob1.mjs	OB1-specific replacements + OUDS updates.
packages/migrate/src/replacements/index.mjs	Builds regex arrays for replace-in-file per source set.
packages/migrate/src/replacements/common.mjs	Shared replacements and generators (spacing/gap/etc.).
packages/migrate/src/replacements/boosted.mjs	Boosted-specific replacements + OUDS updates.
packages/migrate/src/migrate.spec.mjs	Integration tests running the migration over fixtures and validating warnings.
packages/migrate/src/migrate.mjs	Thin wrapper around replace-in-file with computed replacements.
packages/migrate/package.json	Declares the new workspace package and CLI bin entrypoint.
packages/migrate/package-lock.json	Adds a per-package lockfile for migrate (new).
packages/migrate/index.mjs	CLI entrypoint wiring args → migrate + warning output.
packages/migrate/README.md	Documentation for usage/options/examples of the CLI.
package-lock.json	Links the new workspace and updates dependency graph.
build/generate-sri.mjs	Excludes `packages/migrate` from brand SRI generation.
.gitignore	Ignores `packages/migrate/node_modules`.

Files not reviewed (1)

packages/migrate/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-21T12:22:29Z

 sh.config.fatal = true

-const BRANDS = fs.readdirSync('packages', { withFileTypes: true }).filter(file => file.isDirectory()).map(dir => dir.name)
+const BRANDS = fs.readdirSync('packages', { withFileTypes: true }).filter(file => file.isDirectory() && file.name !== 'migrate').map(dir => dir.name)


Hard-coding file.name !== 'migrate' couples this script to a specific directory name. Since the script actually requires packages/<brand>/config.yml, consider filtering directories by the existence of config.yml (or another brand marker) instead, so adding future non-brand workspace packages won’t require updating this script again.

Let's do a more complex test if or when we add another non-brand sub-package

Copilot · 2026-04-21T12:22:30Z

+
+      return options.remove ? '' : (options.replace === undefined ? args[0] : options.replace)
+    }


When options.remove is true, the replacement returns an empty string, which can leave behind empty/whitespace-only class attributes (e.g. the snapshot ends up with class=" "). Consider trimming adjacent whitespace when removing a class token, or add a post-pass to normalize class attributes (collapse spaces and turn class=" " into class="").

This is a fair point, we could add a replacement for class=" " or something more complex to handle class="some-class ".
But right now we only remove for alert-sm and then again I'm not that confident to actually remove while we have dual-mode projects... Should we keep the remove option and handle spaces or should we not remove anything?
What do you think @vprothais?

…ead of common migration

louismaximepiton

Should we add an automatic github workflow to run tests on it ?
Should we add a tick inside the pull request templates to avoid forgetting to update the files ? Also for releases

louismaximepiton · 2026-04-22T14:59:27Z

+  "version": "1.0.0",
+  "main": "index.mjs",
+  "type": "module",
+  "engines": {"node" : ">=20.0.0"},


It might not be good since 24 is quite recent, but 24 sounds better to me

not quite sure about this change, maybe it's better to have a low version to allow people to use it freely, keeping this open for now

louismaximepiton · 2026-04-23T08:50:13Z

Can we add maybe the line where we found the matched expression ? Or maybe the number of times we encounter this in a file.
Can we add a bunch of class for a single component that might be watched ?

louismaximepiton · 2026-04-23T08:53:44Z

@@ -0,0 +1,24 @@
+{
+  "name": "@ouds/web-migrate",
+  "version": "1.0.0",


Should we have the same version number than the principal package ?

louismaximepiton · 2026-04-23T14:21:56Z

+
+export const oudsReplacements = [
+  // Breakpoints
+  ...breakpoints.map(bp => [...getBreakpointsReplacement(bp)]),


It might be a bit too wide and change peoples classes, wdyt ? But it might be great as well

louismaximepiton · 2026-04-24T14:36:53Z

Should we log any change that we've made or is it too much noise ?

louismaximepiton

Love it, still some small questions remaining but tried it on ODS Charts and there are only few false positive. (2 on the whole documentation)

feat: add ouds/web-migrate package

fe15da4

github-project-automation Bot added this to 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 17, 2026

github-project-automation Bot moved this to In Progress / Draft in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 17, 2026

MaxLardenois linked an issue Apr 17, 2026 that may be closed by this pull request

[OUDS] Integrate ouds-migrate inside the monorepo #3520

Open

3 tasks

MaxLardenois added 11 commits April 17, 2026 16:15

fix: stylelint in migrate

e8ef717

fix: stylelint againt

fb18da2

fix: filter migrate out of generate sri

4109988

fix: ignore some eslint stuff

558beb1

feat: separate ouds update from ob1 and boosted migrations

1601d4b

feat: more boosted migrations

5af76a8

feat: more common replacements

bb2d1c8

feat: update README and fix tests

1a9f1d2

Merge branch 'ouds/main' into ouds/main-integrate-ouds-migrate-inside…

b4aa908

…-the-monorepo

fix: after IA review

ee5ed90

feat: more tests

ae52aea

louismaximepiton requested a review from Copilot April 21, 2026 12:15

Copilot started reviewing on behalf of louismaximepiton April 21, 2026 12:16 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

fix: after review

a95c7b3

MaxLardenois marked this pull request as ready for review April 21, 2026 12:56

MaxLardenois requested a review from louismaximepiton as a code owner April 21, 2026 12:56

boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 21, 2026

feat: integrate clearfix, ratio and was-validated in OUDS update inst…

ae4a1a4

…ead of common migration

louismaximepiton reviewed Apr 23, 2026

View reviewed changes

MaxLardenois added 2 commits April 23, 2026 12:13

fix: review first pass

d14f55b

fix: update package lock

063cfc0

louismaximepiton reviewed Apr 24, 2026

View reviewed changes

Add some rules to change

f4898ef

Add some warning links to better convey information

232d175

louismaximepiton approved these changes Apr 24, 2026

View reviewed changes

boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 24, 2026


		return options.remove ? '' : (options.replace === undefined ? args[0] : options.replace)
		}

Conversation

MaxLardenois commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of change

Related issues

Context & Motivation

Description

Checklists

Checklist (for Core Team only)

Progression (for Core Team only)

Live previews

Uh oh!

netlify Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for boosted ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

MaxLardenois Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

MaxLardenois Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

louismaximepiton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

louismaximepiton Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

louismaximepiton Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

louismaximepiton Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

louismaximepiton Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

louismaximepiton Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

louismaximepiton commented Apr 24, 2026

Uh oh!

louismaximepiton left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

MaxLardenois commented Apr 17, 2026 •

edited

Loading

netlify Bot commented Apr 17, 2026 •

edited

Loading

MaxLardenois Apr 21, 2026 •

edited

Loading

MaxLardenois Apr 21, 2026 •

edited

Loading

louismaximepiton Apr 24, 2026 •

edited

Loading

louismaximepiton Apr 23, 2026 •

edited

Loading