Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Adds “AI button” support by introducing new sparkles icons in the docs sprite(s), adding documentation examples, and defining theme tokens/CSS needed to style the component.
Changes:
- Added
sparkles-default/sparkles-coloredsymbols to the docs SVG sprites (sosh/orange/orange-compact). - Added an “AI button” section and metadata to the Buttons documentation page.
- Introduced AI-button border color tokens (per theme) and CSS for AI button styling.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| site/static/sosh/docs/[version]/assets/img/ouds-web-sprite.svg | Adds sparkles symbols for the sosh docs sprite. |
| site/static/orange/docs/[version]/assets/img/ouds-web-sprite.svg | Adds sparkles symbols (including a multi-color variant) for the orange docs sprite. |
| site/static/orange-compact/docs/[version]/assets/img/ouds-web-sprite.svg | Adds sparkles symbols (including a multi-color variant) for the orange-compact docs sprite. |
| site/src/content/docs/components/buttons.mdx | Adds AI button type + documentation examples for AI buttons. |
| scss/_buttons.scss | Adds AI button styling (gradient border + icon swapping). |
| packages/sosh/scss/tokens/_component.scss | Adds manually-defined AI button border tokens for sosh. |
| packages/sosh/scss/tokens/_component-colors-custom-props.scss | Adds a new custom prop used by the sosh AI border token. |
| packages/orange/scss/tokens/_component.scss | Adds manually-defined AI button border tokens for orange. |
| packages/orange-compact/scss/tokens/_component.scss | Adds manually-defined AI button border tokens for orange-compact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 16 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MaxLardenois
left a comment
There was a problem hiding this comment.
Some suggestions
In line with what spec we have for now...
|
|
||
| <BrandSpecific brand={['orange', 'orange-compact']}> | ||
| <Callout type="warning" title="Colored icon"> | ||
| Be aware that `.btn-strong` and `.btn-minimal` variants should use a colored icon to indicate the AI action. It will be automatically replaced when not present or when needed. |
There was a problem hiding this comment.
Is that it?
| Be aware that `.btn-strong` and `.btn-minimal` variants should use a colored icon to indicate the AI action. It will be automatically replaced when not present or when needed. | |
| Be aware that `.btn-strong` and `.btn-minimal` variants should use a colored icon to indicate the AI action. If omitted, the default AI icon will be displayed. |
| </BrandSpecific> | ||
|
|
||
| <Callout type="info"> | ||
| `.btn-default` isn't transparent here, and you might specify `--bs-btn-bg` to make it transparent if needed. |
There was a problem hiding this comment.
| `.btn-default` isn't transparent here, and you might specify `--bs-btn-bg` to make it transparent if needed. | |
| Due to technical limitations, an AI button with`.btn-default` does not have a transparent background. To simulate transparency, set `--bs-btn-bg` to its container background color. |
|
|
||
| <BrandSpecific brand={['orange', 'orange-compact']}> | ||
| <Callout type="warning" title="Colored icon"> | ||
| Be aware that `.btn-strong` and `.btn-minimal` variants should use a colored icon to indicate the AI action. It will be automatically replaced when not present or when needed. |
There was a problem hiding this comment.
Is that it?
| Be aware that `.btn-strong` and `.btn-minimal` variants should use a colored icon to indicate the AI action. It will be automatically replaced when not present or when needed. | |
| Be aware that `.btn-strong` and `.btn-minimal` variants should use a colored icon to indicate the AI action. If omitted, the default AI icon will be displayed. |
| </BrandSpecific> | ||
|
|
||
| <Callout type="info"> | ||
| `.btn-default` isn't transparent here, and you might specify `--bs-btn-bg` to make it transparent if needed. |
There was a problem hiding this comment.
| `.btn-default` isn't transparent here, and you might specify `--bs-btn-bg` to make it transparent if needed. | |
| Due to technical limitations, an AI button with`.btn-default` does not have a transparent background. To simulate transparency, set `--bs-btn-bg` to its container background color. |
|
|
||
| #### Disabled | ||
|
|
||
| AI buttons use a `<button>` element, simply add the `disabled` boolean attribute to it. Disabled AI buttons have `pointer-events: none` applied to, preventing hover and active states from triggering. |
There was a problem hiding this comment.
| AI buttons use a `<button>` element, simply add the `disabled` boolean attribute to it. Disabled AI buttons have `pointer-events: none` applied to, preventing hover and active states from triggering. | |
| AI buttons typically use the `<button>` element. To disable an AI button, add the `disabled` boolean attribute. Disabled AI buttons have `pointer-events: none` applied to, preventing hover and active states from triggering. |
| --- | ||
|
|
||
| ## v1.3.0 | ||
|
|
There was a problem hiding this comment.
| <hr /> |
|
|
||
| #### AI button | ||
|
|
||
| - <span class="tag tag-small tag-positive"><span class="tag-status-icon"></span>New</span> AI button has been implemented. Read more in our [buttons page]([[docsref:/components/buttons#ai-button]]). |
There was a problem hiding this comment.
Shouldn't this be draft for now?
| } | ||
|
|
||
| // No transparency on the button | ||
| .btn-default.btn-ai:where(:not(:active, [class*="loading-"], :disabled, [aria-disabled="true"], .btn-on-colored-bg)) { |
There was a problem hiding this comment.
Is the :where necessary here?
Types of change
Related issues
Closes #3522
Context & Motivation
Read #3522
Description
Add some CSS and documentation to handle AI Button.
Checklists
Checklist (for Core Team only)
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews