feat: add Label references to utilities and docs#3621
Conversation
github-project-automation
Bot
moved this to In Progress / Draft
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
boosted-bot
moved this from In Progress / Draft
to Need Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
louismaximepiton
left a comment
louismaximepiton
left a comment
There was a problem hiding this comment.
I think the changes in */_semantics.scss files aren't needed since the variables are already defined in the files. In general, these files shouldn't be changed at all, but with tokenator automated PRs.
.bundlewatch.json needs to be updated as well for the CI to pass correctly.
boosted-bot
moved this from Need Dev Review
to Dev Review In Progress
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
…pdated changelog with labels utilities
boosted-bot
moved this from Dev Review In Progress
to Need Lead Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
| /* rtl:end:remove */ | ||
|
|
||
| .fs-lxl { | ||
| font-size: var(--bs-font-size-label-xlarge); |
There was a problem hiding this comment.
We decided to not generate a max-width property for label ref since it was often not needed in components. Therefore get-font-size mixin doesn't generate the max-width for this ref. As a result we don't have it either in these helpers. But I think that it should be present in this case for this usage.
There was a problem hiding this comment.
There is a section at the end of https://deploy-preview-3621--boosted.netlify.app/orange/docs/1.3/foundation/typography/#text-style-for-custom-components explaining how to use label typography references in custom component. This section could be removed since there is now a helper that could be used. The documentation of this mixin is still relevant but it could be explained later in a page we want to create about all useful mixin for creating components.
boosted-bot
moved this from Need Lead Dev Review
to Dev Review In Progress
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
MaxLardenois
left a comment
MaxLardenois
left a comment
There was a problem hiding this comment.
A little suggestion here
| - <span class="tag tag-small tag-positive"><span class="tag-status-icon"></span>New</span> Labels have been added to font size text utilities : `.fs-lxl`, `.fs-ll`, `.fs-lm`, `.fs-ls` are now available. | ||
| See [Regular Texts]([[docsref:foundation/typography#regular-texts]]) for more details. |
There was a problem hiding this comment.
Just to have the same phrasing as the others
| - <span class="tag tag-small tag-positive"><span class="tag-status-icon"></span>New</span> Labels have been added to font size text utilities : `.fs-lxl`, `.fs-ll`, `.fs-lm`, `.fs-ls` are now available. | |
| See [Regular Texts]([[docsref:foundation/typography#regular-texts]]) for more details. | |
| - <span class="tag tag-small tag-positive"><span class="tag-status-icon"></span>New</span> Labels have been added to font size text utilities : `.fs-lxl`, `.fs-ll`, `.fs-lm`, `.fs-ls` are now available. Read more in our [typography page]([[docsref:foundation/typography#regular-texts]]). |
Types of change
Related issues
Closes #3610
Context & Motivation
Description
Add label-{small|medium|large|xlarge} references to classes fs-* and to Typography and Text docs.
Checklists
Checklist (for Core Team only)
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews