feat: add Label references to utilities and docs #3621
+125
−16
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
louismaximepiton marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
There was a problem hiding this comment. There is a section at the end of https://deploy-preview-3621--boosted.netlify.app/orange/docs/1.3/foundation/typography/#text-style-for-custom-components explaining how to use label typography references in custom component. This section could be removed since there is now a helper that could be used. The documentation of this mixin is still relevant but it could be explained later in a page we want to create about all useful mixin for creating components. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,11 @@ export const fontSize = [ | |
| "body-large", | ||
| "body-medium", | ||
| "body-small", | ||
| "code-medium", | ||
| "label-xlarge", | ||
| "label-large", | ||
| "label-medium", | ||
| "label-small" | ||
| ] | ||
|
|
||
| export const screenSize = [ | ||
|
|
@@ -140,13 +144,17 @@ These classes change the `font-size` but also the `line-height`, the `letter-spa | |
| {level === 'body-medium' && (<>Body medium (<code>{'.fs-bm'}</code>)</>)} | ||
| {level === 'body-small' && (<>Body small (<code>{'.fs-bs'}</code>)</>)} | ||
| {level === 'code-medium' && (<>Code medium (<code>{'.fs-cm'}</code>)</>)} | ||
| {level === 'label-xlarge' && (<>Label xlarge (<code>{'.fs-lxl'}</code>)</>)} | ||
| {level === 'label-large' && (<>Label large (<code>{'.fs-ll'}</code>)</>)} | ||
| {level === 'label-medium' && (<>Label medium (<code>{'.fs-lm'}</code>)</>)} | ||
| {level === 'label-small' && (<>Label small (<code>{'.fs-ls'}</code>)</>)} | ||
| </td> | ||
| { | ||
| screenSize.map((size) => ( | ||
| <td> | ||
| {(level !== 'code-medium' && !level.includes('label-')) | ||
| && (<><code>{(getTokenValue(`$ouds-font-size-${level}-${size}`).slice(0, -2)) / 16}rem</code> ({getTokenValue(`$ouds-font-size-${level}-${size}`)})</>)} | ||
| {(level === 'code-medium' || level.includes('label-')) | ||
| && (<><code>{(getTokenValue(`$ouds-font-size-${level}`).slice(0, -2)) / 16}rem</code> ({getTokenValue(`$ouds-font-size-${level}`)})</>)} | ||
| </td> | ||
| )) | ||
|
|
@@ -188,11 +196,15 @@ These classes change the `font-size` but also the `line-height`, the `letter-spa | |
| {level === 'body-medium' && (<>Body medium (<code>{'.fs-bm'}</code>)</>)} | ||
| {level === 'body-small' && (<>Body small (<code>{'.fs-bs'}</code>)</>)} | ||
| {level === 'code-medium' && (<>Code medium (<code>{'.fs-cm'}</code>)</>)} | ||
| {level === 'label-xlarge' && (<>Label xlarge (<code>{'.fs-lxl'}</code>)</>)} | ||
| {level === 'label-large' && (<>Label large (<code>{'.fs-ll'}</code>)</>)} | ||
| {level === 'label-medium' && (<>Label medium (<code>{'.fs-lm'}</code>)</>)} | ||
| {level === 'label-small' && (<>Label small (<code>{'.fs-ls'}</code>)</>)} | ||
| </td> | ||
| { | ||
| screenSize.map((size) => ( | ||
| <td> | ||
| {(level !== 'code-medium' && !level.includes('label-')) | ||
| && ( | ||
| <ul class="mb-none ps-medium"> | ||
| <li><code class="text-default">font-size</code>: <b>{(getTokenValue(`$ouds-font-size-${level}-${size}`).slice(0, -2)) / 16}rem</b></li> | ||
|
|
@@ -201,7 +213,7 @@ These classes change the `font-size` but also the `line-height`, the `letter-spa | |
| <li><code>max-width</code>: {(getTokenValue(`$ouds-size-max-width-${level}-${size}`).slice(0, -2)) / 16}rem</li> | ||
| </ul> | ||
| )} | ||
| {(level === 'code-medium' || level.includes('label-')) | ||
| && ( | ||
| <ul class="mb-none ps-medium"> | ||
| <li><code class="text-default">font-size</code>: <b>{(getTokenValue(`$ouds-font-size-${level}`).slice(0, -2)) / 16}rem</b></li> | ||
|
|
@@ -230,7 +242,11 @@ These classes change the `font-size` but also the `line-height`, the `letter-spa | |
| <p class="fs-bl">.fs-bl text</p> | ||
| <p class="fs-bm">.fs-bm text</p> | ||
| <p class="fs-bs">.fs-bs text</p> | ||
| <p class="fs-cm font-monospace">.fs-cm.font-monospace text</p> | ||
| <p class="fs-lxl">.fs-lxl text</p> | ||
| <p class="fs-ll">.fs-ll text</p> | ||
| <p class="fs-lm">.fs-lm text</p> | ||
| <p class="fs-ls">.fs-ls text</p>`} /> | ||
|
|
||
| Customize your available `font-size`s by modifying the `$ouds-font-sizes` Sass map. | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to not generate a
max-widthproperty forlabelref since it was often not needed in components. Thereforeget-font-sizemixin doesn't generate the max-width for this ref. As a result we don't have it either in these helpers. But I think that it should be present in this case for this usage.