Add integration test for HURL_NO_HEADER.

jcamiel · hurl-bot · commit 847d5a2f0c47 · 2026-05-21T06:09:51.000Z
diff --git a/integration/hurl/tests_failed/no_header/no_header.err b/integration/hurl/tests_failed/no_header/no_header.err
@@ -0,0 +1 @@
+error: Missing header name
diff --git a/integration/hurl/tests_failed/no_header/no_header.exit b/integration/hurl/tests_failed/no_header/no_header.exit
@@ -0,0 +1 @@
+1
diff --git a/integration/hurl/tests_failed/no_header/no_header.hurl b/integration/hurl/tests_failed/no_header/no_header.hurl
@@ -0,0 +1 @@
+# Noop
diff --git a/integration/hurl/tests_failed/no_header/no_header.ps1 b/integration/hurl/tests_failed/no_header/no_header.ps1
@@ -0,0 +1,4 @@
+Set-StrictMode -Version latest
+$ErrorActionPreference = 'Stop'
+
+hurl --no-header foo --no-header '' tests_failed/no_header/no_header.hurl
diff --git a/integration/hurl/tests_failed/no_header/no_header.sh b/integration/hurl/tests_failed/no_header/no_header.sh
@@ -0,0 +1,4 @@
+#!/bin/bash
+set -Eeuo pipefail
+
+hurl --no-header foo --no-header '' tests_failed/no_header/no_header.hurl
diff --git a/integration/hurl/tests_failed/no_header/no_header_env_var.err b/integration/hurl/tests_failed/no_header/no_header_env_var.err
@@ -0,0 +1 @@
+error: Missing header name (HURL_NO_HEADER environment variable)
diff --git a/integration/hurl/tests_failed/no_header/no_header_env_var.exit b/integration/hurl/tests_failed/no_header/no_header_env_var.exit
@@ -0,0 +1 @@
+1
diff --git a/integration/hurl/tests_failed/no_header/no_header_env_var.ps1 b/integration/hurl/tests_failed/no_header/no_header_env_var.ps1
@@ -0,0 +1,5 @@
+Set-StrictMode -Version latest
+$ErrorActionPreference = 'Stop'
+
+$env:HURL_NO_HEADER='foo|'
+hurl tests_failed/no_header/no_header.hurl
diff --git a/integration/hurl/tests_failed/no_header/no_header_env_var.sh b/integration/hurl/tests_failed/no_header/no_header_env_var.sh
@@ -0,0 +1,5 @@
+#!/bin/bash
+set -Eeuo pipefail
+
+export HURL_NO_HEADER="foo|"
+hurl tests_failed/no_header/no_header.hurl
diff --git a/integration/hurl/tests_ok/no_header/no_header_env_var.out b/integration/hurl/tests_ok/no_header/no_header_env_var.out
@@ -0,0 +1 @@
+Hello World!
diff --git a/integration/hurl/tests_ok/no_header/no_header_env_var.ps1 b/integration/hurl/tests_ok/no_header/no_header_env_var.ps1
@@ -0,0 +1,5 @@
+Set-StrictMode -Version latest
+$ErrorActionPreference = 'Stop'
+
+$env:HURL_NO_HEADER='user-agent |Accept'
+hurl tests_ok/no_header/no_header.hurl
diff --git a/integration/hurl/tests_ok/no_header/no_header_env_var.sh b/integration/hurl/tests_ok/no_header/no_header_env_var.sh
@@ -0,0 +1,5 @@
+#!/bin/bash
+set -Eeuo pipefail
+
+export HURL_NO_HEADER="user-agent |Accept"
+hurl tests_ok/no_header/no_header.hurl
diff --git a/packages/hurl/src/cli/options/args.rs b/packages/hurl/src/cli/options/args.rs
@@ -743,11 +743,11 @@ fn no_cookie_store(arg_matches: &ArgMatches, default_value: bool) -> bool {
 }
 
 fn no_headers(arg_matches: &ArgMatches, default_value: Vec<String>) -> Vec<String> {
-    let mut no_headers = default_value;
-    if let Some(no_header) = get_strings(arg_matches, "no_header") {
-        no_headers.extend(no_header);
+    let mut all_no_headers = default_value;
+    if let Some(no_headers) = get_strings(arg_matches, "no_header") {
+        all_no_headers.extend(no_headers);
     }
-    no_headers
+    all_no_headers
 }
 
 fn no_proxy(arg_matches: &ArgMatches, default_value: Option<String>) -> Option<String> {
diff --git a/packages/hurl/src/cli/options/context.rs b/packages/hurl/src/cli/options/context.rs
@@ -166,10 +166,7 @@ impl RunContext {
             .map(|v| v.as_str())
     }
 
-    /// Returns the map of Hurl headers injected by environment variables.
-    ///
-    /// Environment variables are prefixed with `HURL_VARIABLE_` and returned values have their name
-    /// stripped of this prefix.
+    /// Returns the Hurl headers injected by environment variables.
     pub fn header_env_var(&self) -> Option<&str> {
         self.hurl_env_vars.get(HURL_HEADER).map(|v| v.as_str())
     }
@@ -262,11 +259,6 @@ impl RunContext {
         self.hurl_env_vars.get(HURL_USER_AGENT).map(|v| v.as_str())
     }
 
-    /// Returns the env var for suppressing output.
-    pub fn no_output_env_var(&self) -> Option<bool> {
-        self.get_env_var_bool(HURL_NO_OUTPUT)
-    }
-
     /// Returns the env var for ignoring asserts.
     pub fn no_assert_env_var(&self) -> Option<bool> {
         self.get_env_var_bool(HURL_NO_ASSERT)
@@ -278,12 +270,15 @@ impl RunContext {
     }
 
     /// Returns the env var for headers to remove from requests.
-    ///
-    /// Header names are separated by `|`.
     pub fn no_header_env_var(&self) -> Option<&str> {
         self.hurl_env_vars.get(HURL_NO_HEADER).map(|v| v.as_str())
     }
 
+    /// Returns the env var for suppressing output.
+    pub fn no_output_env_var(&self) -> Option<bool> {
+        self.get_env_var_bool(HURL_NO_OUTPUT)
+    }
+
     /// Returns the env var for disabling pretty output.
     pub fn no_pretty_env_var(&self) -> Option<bool> {
         self.get_env_var_bool(HURL_NO_PRETTY)
diff --git a/packages/hurl/src/cli/options/env_vars.rs b/packages/hurl/src/cli/options/env_vars.rs
@@ -247,7 +247,7 @@ fn no_headers(
     if let Some(no_header) = context.no_header_env_var() {
         let no_headers = no_header
             .split("|")
-            .map(|h| h.to_string())
+            .map(|h| h.trim().to_string())
             .collect::<Vec<_>>();
         for h in &no_headers {
             if h.is_empty() {
diff --git a/packages/hurl/src/cli/options/mod.rs b/packages/hurl/src/cli/options/mod.rs
@@ -388,6 +388,14 @@ impl CliOptions {
         let netrc_file = self.netrc_file.clone();
         let netrc_optional = self.netrc_optional;
         let no_assert = self.no_assert;
+        let mut no_headers = Vec::new();
+        for no_header in self.no_headers.iter() {
+            let no_header = no_header.trim().to_string();
+            if no_header.is_empty() {
+                return Err(CliError::InvalidOption("Missing header name".to_string()));
+            }
+            no_headers.push(no_header);
+        }
         let no_headers = self.no_headers.clone();
         let no_proxy = self.no_proxy.clone();
         let output = self.output.clone();

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+error: Missing header name (HURL_NO_HEADER environment variable)`