Skip to content

Commit 554a17c

Browse files
committed
review: resolve all comments of review
1 parent c71b54b commit 554a17c

22 files changed

Lines changed: 356 additions & 266 deletions

app/lib/l10n/gen/ouds_flutter_app_localizations.dart

Lines changed: 54 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -589,107 +589,112 @@ abstract class AppLocalizations {
589589
/// **'Trailing action count'**
590590
String get app_components_common_trailingActionCount_label;
591591

592-
/// No description provided for @app_components_bottomSheet_label.
592+
/// No description provided for @app_components_bottomSheet_tech.
593593
///
594594
/// In en, this message translates to:
595-
/// **'Bottom Sheet'**
596-
String get app_components_bottomSheet_label;
595+
/// **'Bottom sheet'**
596+
String get app_components_bottomSheet_tech;
597597

598-
/// No description provided for @app_components_bottomSheet_modal_label.
598+
/// No description provided for @app_components_bottomSheet_description_text.
599599
///
600600
/// In en, this message translates to:
601-
/// **'Modal bottom sheet'**
602-
String get app_components_bottomSheet_modal_label;
601+
/// **'Bottom sheets show secondary content anchored to the bottom of the screen.'**
602+
String get app_components_bottomSheet_description_text;
603603

604-
/// No description provided for @app_components_bottomSheet_modal_description_text.
604+
/// No description provided for @app_components_bottomSheet_sheetContent_text.
605605
///
606606
/// In en, this message translates to:
607-
/// **'Modal bottom sheet displays content that temporarily blocks interaction with the main screen.'**
608-
String get app_components_bottomSheet_modal_description_text;
607+
/// **'Bottom sheet content.\n\nLorem ipsum dolor sit amet, consectetur adipiscing elit. Donec bibendum erat vel lectus bibendum ultricies. Fusce non vestibulum nibh, sed fermentum purus. Quisque at dui ipsum. Sed maximus nibh vel vestibulum aliquam. Donec porta quam blandit elit ultrices, eget rhoncus mauris faucibus. Duis a elit sit amet tellus aliquam pellentesque. Sed in felis quis ex lacinia suscipit. Vestibulum vel tempus ante, sit amet viverra sem. Proin venenatis urna sit amet tristique consequat. Phasellus ultricies odio non risus vulputate, vel pulvinar sapien pretium. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Proin suscipit purus augue, aliquet finibus libero malesuada eu. Nulla non magna mi.'**
608+
String get app_components_bottomSheet_sheetContent_text;
609609

610-
/// No description provided for @app_components_bottomSheet_standard_label.
610+
/// No description provided for @app_components_bottomSheet_standardBottomSheet_tech.
611611
///
612612
/// In en, this message translates to:
613613
/// **'Standard bottom sheet'**
614-
String get app_components_bottomSheet_standard_label;
614+
String get app_components_bottomSheet_standardBottomSheet_tech;
615615

616-
/// No description provided for @app_components_bottomSheet_standard_description_text.
616+
/// No description provided for @app_components_bottomSheet_standardBottomSheet_description_text.
617617
///
618618
/// In en, this message translates to:
619619
/// **'Standard bottom sheets co-exist with the main screen content, allowing users to interact with both simultaneously.'**
620-
String get app_components_bottomSheet_standard_description_text;
620+
String get app_components_bottomSheet_standardBottomSheet_description_text;
621621

622-
/// No description provided for @app_components_bottomSheet_dragHandle_label.
622+
/// No description provided for @app_components_bottomSheet_standardBottomSheet_sheetPeekHeight_tech.
623623
///
624624
/// In en, this message translates to:
625-
/// **'Drag handle'**
626-
String get app_components_bottomSheet_dragHandle_label;
625+
/// **'Sheet peek height'**
626+
String
627+
get app_components_bottomSheet_standardBottomSheet_sheetPeekHeight_tech;
627628

628-
/// No description provided for @app_components_bottomSheet_sheetGesturesEnabled_label.
629+
/// No description provided for @app_components_bottomSheet_standardBottomSheet_sheetPeekHeightSuffix_tech.
629630
///
630631
/// In en, this message translates to:
631-
/// **'Sheet gestures enabled'**
632-
String get app_components_bottomSheet_sheetGesturesEnabled_label;
632+
/// **'dp'**
633+
String
634+
get app_components_bottomSheet_standardBottomSheet_sheetPeekHeightSuffix_tech;
633635

634-
/// No description provided for @app_components_bottomSheet_sheetSwipeEnabled_label.
636+
/// No description provided for @app_components_bottomSheet_standardBottomSheet_sheetDragHandle_tech.
635637
///
636638
/// In en, this message translates to:
637-
/// **'Swipe enabled'**
638-
String get app_components_bottomSheet_sheetSwipeEnabled_label;
639+
/// **'Sheet drag handle'**
640+
String
641+
get app_components_bottomSheet_standardBottomSheet_sheetDragHandle_tech;
639642

640-
/// No description provided for @app_components_bottomSheet_sheetPeekHeight_label.
643+
/// No description provided for @app_components_bottomSheet_standardBottomSheet_sheetSwipeEnabled_tech.
641644
///
642645
/// In en, this message translates to:
643-
/// **'Peek height'**
644-
String get app_components_bottomSheet_sheetPeekHeight_label;
646+
/// **'Sheet swipe enabled'**
647+
String
648+
get app_components_bottomSheet_standardBottomSheet_sheetSwipeEnabled_tech;
645649

646-
/// No description provided for @app_components_bottomSheet_sheetPeekHeightSuffix_label.
650+
/// No description provided for @app_components_bottomSheet_standardBottomSheet_sheetValue_tech.
647651
///
648652
/// In en, this message translates to:
649-
/// **'dp'**
650-
String get app_components_bottomSheet_sheetPeekHeightSuffix_label;
653+
/// **'Sheet value'**
654+
String get app_components_bottomSheet_standardBottomSheet_sheetValue_tech;
651655

652-
/// No description provided for @app_components_bottomSheet_sheetValue_label.
656+
/// No description provided for @app_components_bottomSheet_standardBottomSheet_collapse_label.
653657
///
654658
/// In en, this message translates to:
655-
/// **'Sheet value'**
656-
String get app_components_bottomSheet_sheetValue_label;
659+
/// **'Collapse'**
660+
String get app_components_bottomSheet_standardBottomSheet_collapse_label;
657661

658-
/// No description provided for @app_components_bottomSheet_sheetValue_expanded_label.
662+
/// No description provided for @app_components_bottomSheet_modalBottomSheet_tech.
659663
///
660664
/// In en, this message translates to:
661-
/// **'Expanded'**
662-
String get app_components_bottomSheet_sheetValue_expanded_label;
665+
/// **'Modal bottom sheet'**
666+
String get app_components_bottomSheet_modalBottomSheet_tech;
663667

664-
/// No description provided for @app_components_bottomSheet_sheetValue_partiallyExpanded_label.
668+
/// No description provided for @app_components_bottomSheet_modalBottomSheet_description_text.
665669
///
666670
/// In en, this message translates to:
667-
/// **'Partially expanded'**
668-
String get app_components_bottomSheet_sheetValue_partiallyExpanded_label;
671+
/// **'Modal bottom sheet displays content that temporarily blocks interaction with the main screen.'**
672+
String get app_components_bottomSheet_modalBottomSheet_description_text;
669673

670-
/// No description provided for @app_components_bottomSheet_sheetContent_text.
674+
/// No description provided for @app_components_bottomSheet_modalBottomSheet_dragHandle_tech.
671675
///
672676
/// In en, this message translates to:
673-
/// **'Bottom sheet content.\n\nLorem ipsum dolor sit amet, consectetur adipiscing elit. Donec bibendum erat vel lectus bibendum ultricies. Fusce non vestibulum nibh, sed fermentum purus. Quisque at dui ipsum. Sed maximus nibh vel vestibulum aliquam. Donec porta quam blandit elit ultrices, eget rhoncus mauris faucibus. Duis a elit sit amet tellus aliquam pellentesque. Sed in felis quis ex lacinia suscipit. Vestibulum vel tempus ante, sit amet viverra sem.'**
674-
String get app_components_bottomSheet_sheetContent_text;
677+
/// **'Drag handle'**
678+
String get app_components_bottomSheet_modalBottomSheet_dragHandle_tech;
675679

676-
/// No description provided for @app_components_bottomSheet_modal_showButton_label.
680+
/// No description provided for @app_components_bottomSheet_modalBottomSheet_sheetGestureEnabled_tech.
677681
///
678682
/// In en, this message translates to:
679-
/// **'Show bottom sheet'**
680-
String get app_components_bottomSheet_modal_showButton_label;
683+
/// **'Sheet gestures enabled'**
684+
String
685+
get app_components_bottomSheet_modalBottomSheet_sheetGestureEnabled_tech;
681686

682-
/// No description provided for @app_components_bottomSheet_modal_close_label.
687+
/// No description provided for @app_components_bottomSheet_modalBottomSheet_showButton_label.
683688
///
684689
/// In en, this message translates to:
685-
/// **'Close'**
686-
String get app_components_bottomSheet_modal_close_label;
690+
/// **'Show bottom sheet'**
691+
String get app_components_bottomSheet_modalBottomSheet_showButton_label;
687692

688-
/// No description provided for @app_components_bottomSheet_standard_collapse_label.
693+
/// No description provided for @app_components_bottomSheet_modalBottomSheet_close_label.
689694
///
690695
/// In en, this message translates to:
691-
/// **'Collapse'**
692-
String get app_components_bottomSheet_standard_collapse_label;
696+
/// **'Close'**
697+
String get app_components_bottomSheet_modalBottomSheet_close_label;
693698

694699
/// No description provided for @app_components_button_label.
695700
///

app/lib/l10n/gen/ouds_flutter_app_localizations_ar.dart

Lines changed: 35 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -266,64 +266,75 @@ class AppLocalizationsAr extends AppLocalizations {
266266
'Trailing action count';
267267

268268
@override
269-
String get app_components_bottomSheet_label => 'Bottom Sheet';
269+
String get app_components_bottomSheet_tech => 'Bottom sheet';
270270

271271
@override
272-
String get app_components_bottomSheet_modal_label => 'Modal bottom sheet';
272+
String get app_components_bottomSheet_description_text =>
273+
'تعرض الأوراق السفلية محتوى ثانوياً مثبتاً في أسفل الشاشة.';
273274

274275
@override
275-
String get app_components_bottomSheet_modal_description_text =>
276-
'تعرض الـ Bottom Sheet النموذجية محتوى يحجب مؤقتاً التفاعل مع الشاشة الرئيسية.';
276+
String get app_components_bottomSheet_sheetContent_text =>
277+
'محتوى الـ Bottom Sheet.\n\nLorem ipsum dolor sit amet, consectetur adipiscing elit. Donec bibendum erat vel lectus bibendum ultricies. Fusce non vestibulum nibh, sed fermentum purus. Quisque at dui ipsum. Sed maximus nibh vel vestibulum aliquam. Donec porta quam blandit elit ultrices, eget rhoncus mauris faucibus. Duis a elit sit amet tellus aliquam pellentesque. Sed in felis quis ex lacinia suscipit. Vestibulum vel tempus ante, sit amet viverra sem. Proin venenatis urna sit amet tristique consequat. Phasellus ultricies odio non risus vulputate, vel pulvinar sapien pretium. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Proin suscipit purus augue, aliquet finibus libero malesuada eu. Nulla non magna mi.';
277278

278279
@override
279-
String get app_components_bottomSheet_standard_label =>
280+
String get app_components_bottomSheet_standardBottomSheet_tech =>
280281
'Standard bottom sheet';
281282

282283
@override
283-
String get app_components_bottomSheet_standard_description_text =>
284+
String get app_components_bottomSheet_standardBottomSheet_description_text =>
284285
'تتعايش الـ Bottom Sheet القياسية مع محتوى الشاشة الرئيسية، مما يتيح التفاعل مع الاثنين في نفس الوقت.';
285286

286287
@override
287-
String get app_components_bottomSheet_dragHandle_label => 'مقبض السحب';
288+
String
289+
get app_components_bottomSheet_standardBottomSheet_sheetPeekHeight_tech =>
290+
'Sheet peek height';
288291

289292
@override
290-
String get app_components_bottomSheet_sheetGesturesEnabled_label =>
291-
'تفعيل الإيماءات';
293+
String
294+
get app_components_bottomSheet_standardBottomSheet_sheetPeekHeightSuffix_tech =>
295+
'dp';
292296

293297
@override
294-
String get app_components_bottomSheet_sheetSwipeEnabled_label =>
295-
'تفعيل السحب';
298+
String
299+
get app_components_bottomSheet_standardBottomSheet_sheetDragHandle_tech =>
300+
'Sheet drag handle';
296301

297302
@override
298-
String get app_components_bottomSheet_sheetPeekHeight_label =>
299-
'الارتفاع المرئي';
303+
String
304+
get app_components_bottomSheet_standardBottomSheet_sheetSwipeEnabled_tech =>
305+
'Sheet swipe enabled';
300306

301307
@override
302-
String get app_components_bottomSheet_sheetPeekHeightSuffix_label => 'dp';
308+
String get app_components_bottomSheet_standardBottomSheet_sheetValue_tech =>
309+
'Sheet value';
303310

304311
@override
305-
String get app_components_bottomSheet_sheetValue_label => 'قيمة الورقة';
312+
String get app_components_bottomSheet_standardBottomSheet_collapse_label =>
313+
'طي';
306314

307315
@override
308-
String get app_components_bottomSheet_sheetValue_expanded_label => 'موسعة';
316+
String get app_components_bottomSheet_modalBottomSheet_tech =>
317+
'Modal bottom sheet';
309318

310319
@override
311-
String get app_components_bottomSheet_sheetValue_partiallyExpanded_label =>
312-
'موسعة جزئياً';
320+
String get app_components_bottomSheet_modalBottomSheet_description_text =>
321+
'تعرض الـ Bottom Sheet النموذجية محتوى يحجب مؤقتاً التفاعل مع الشاشة الرئيسية.';
313322

314323
@override
315-
String get app_components_bottomSheet_sheetContent_text =>
316-
'محتوى الـ Bottom Sheet.\n\nLorem ipsum dolor sit amet, consectetur adipiscing elit. Donec bibendum erat vel lectus bibendum ultricies. Fusce non vestibulum nibh, sed fermentum purus. Quisque at dui ipsum. Sed maximus nibh vel vestibulum aliquam.';
324+
String get app_components_bottomSheet_modalBottomSheet_dragHandle_tech =>
325+
'Drag handle';
317326

318327
@override
319-
String get app_components_bottomSheet_modal_showButton_label =>
320-
'إظهار الورقة السفلية';
328+
String
329+
get app_components_bottomSheet_modalBottomSheet_sheetGestureEnabled_tech =>
330+
'Sheet gestures enabled';
321331

322332
@override
323-
String get app_components_bottomSheet_modal_close_label => 'إغلاق';
333+
String get app_components_bottomSheet_modalBottomSheet_showButton_label =>
334+
'إظهار الورقة السفلية';
324335

325336
@override
326-
String get app_components_bottomSheet_standard_collapse_label => 'طي';
337+
String get app_components_bottomSheet_modalBottomSheet_close_label => 'إغلاق';
327338

328339
@override
329340
String get app_components_button_label => 'Button';

app/lib/l10n/gen/ouds_flutter_app_localizations_en.dart

Lines changed: 35 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -266,63 +266,75 @@ class AppLocalizationsEn extends AppLocalizations {
266266
'Trailing action count';
267267

268268
@override
269-
String get app_components_bottomSheet_label => 'Bottom Sheet';
269+
String get app_components_bottomSheet_tech => 'Bottom sheet';
270270

271271
@override
272-
String get app_components_bottomSheet_modal_label => 'Modal bottom sheet';
272+
String get app_components_bottomSheet_description_text =>
273+
'Bottom sheets show secondary content anchored to the bottom of the screen.';
273274

274275
@override
275-
String get app_components_bottomSheet_modal_description_text =>
276-
'Modal bottom sheet displays content that temporarily blocks interaction with the main screen.';
276+
String get app_components_bottomSheet_sheetContent_text =>
277+
'Bottom sheet content.\n\nLorem ipsum dolor sit amet, consectetur adipiscing elit. Donec bibendum erat vel lectus bibendum ultricies. Fusce non vestibulum nibh, sed fermentum purus. Quisque at dui ipsum. Sed maximus nibh vel vestibulum aliquam. Donec porta quam blandit elit ultrices, eget rhoncus mauris faucibus. Duis a elit sit amet tellus aliquam pellentesque. Sed in felis quis ex lacinia suscipit. Vestibulum vel tempus ante, sit amet viverra sem. Proin venenatis urna sit amet tristique consequat. Phasellus ultricies odio non risus vulputate, vel pulvinar sapien pretium. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Proin suscipit purus augue, aliquet finibus libero malesuada eu. Nulla non magna mi.';
277278

278279
@override
279-
String get app_components_bottomSheet_standard_label =>
280+
String get app_components_bottomSheet_standardBottomSheet_tech =>
280281
'Standard bottom sheet';
281282

282283
@override
283-
String get app_components_bottomSheet_standard_description_text =>
284+
String get app_components_bottomSheet_standardBottomSheet_description_text =>
284285
'Standard bottom sheets co-exist with the main screen content, allowing users to interact with both simultaneously.';
285286

286287
@override
287-
String get app_components_bottomSheet_dragHandle_label => 'Drag handle';
288+
String
289+
get app_components_bottomSheet_standardBottomSheet_sheetPeekHeight_tech =>
290+
'Sheet peek height';
288291

289292
@override
290-
String get app_components_bottomSheet_sheetGesturesEnabled_label =>
291-
'Sheet gestures enabled';
293+
String
294+
get app_components_bottomSheet_standardBottomSheet_sheetPeekHeightSuffix_tech =>
295+
'dp';
292296

293297
@override
294-
String get app_components_bottomSheet_sheetSwipeEnabled_label =>
295-
'Swipe enabled';
298+
String
299+
get app_components_bottomSheet_standardBottomSheet_sheetDragHandle_tech =>
300+
'Sheet drag handle';
296301

297302
@override
298-
String get app_components_bottomSheet_sheetPeekHeight_label => 'Peek height';
303+
String
304+
get app_components_bottomSheet_standardBottomSheet_sheetSwipeEnabled_tech =>
305+
'Sheet swipe enabled';
299306

300307
@override
301-
String get app_components_bottomSheet_sheetPeekHeightSuffix_label => 'dp';
308+
String get app_components_bottomSheet_standardBottomSheet_sheetValue_tech =>
309+
'Sheet value';
302310

303311
@override
304-
String get app_components_bottomSheet_sheetValue_label => 'Sheet value';
312+
String get app_components_bottomSheet_standardBottomSheet_collapse_label =>
313+
'Collapse';
305314

306315
@override
307-
String get app_components_bottomSheet_sheetValue_expanded_label => 'Expanded';
316+
String get app_components_bottomSheet_modalBottomSheet_tech =>
317+
'Modal bottom sheet';
308318

309319
@override
310-
String get app_components_bottomSheet_sheetValue_partiallyExpanded_label =>
311-
'Partially expanded';
320+
String get app_components_bottomSheet_modalBottomSheet_description_text =>
321+
'Modal bottom sheet displays content that temporarily blocks interaction with the main screen.';
312322

313323
@override
314-
String get app_components_bottomSheet_sheetContent_text =>
315-
'Bottom sheet content.\n\nLorem ipsum dolor sit amet, consectetur adipiscing elit. Donec bibendum erat vel lectus bibendum ultricies. Fusce non vestibulum nibh, sed fermentum purus. Quisque at dui ipsum. Sed maximus nibh vel vestibulum aliquam. Donec porta quam blandit elit ultrices, eget rhoncus mauris faucibus. Duis a elit sit amet tellus aliquam pellentesque. Sed in felis quis ex lacinia suscipit. Vestibulum vel tempus ante, sit amet viverra sem.';
324+
String get app_components_bottomSheet_modalBottomSheet_dragHandle_tech =>
325+
'Drag handle';
316326

317327
@override
318-
String get app_components_bottomSheet_modal_showButton_label =>
319-
'Show bottom sheet';
328+
String
329+
get app_components_bottomSheet_modalBottomSheet_sheetGestureEnabled_tech =>
330+
'Sheet gestures enabled';
320331

321332
@override
322-
String get app_components_bottomSheet_modal_close_label => 'Close';
333+
String get app_components_bottomSheet_modalBottomSheet_showButton_label =>
334+
'Show bottom sheet';
323335

324336
@override
325-
String get app_components_bottomSheet_standard_collapse_label => 'Collapse';
337+
String get app_components_bottomSheet_modalBottomSheet_close_label => 'Close';
326338

327339
@override
328340
String get app_components_button_label => 'Button';

0 commit comments

Comments
 (0)