Skip to content

chore:update Bottom Bar with animation indicator#771

Open
AhmedAmineZr wants to merge 5 commits into
prepare-new-version-2.0.0from
633-for-tab-bar-component-update-the-animation-of-the-selected-tab-indicator
Open

chore:update Bottom Bar with animation indicator#771
AhmedAmineZr wants to merge 5 commits into
prepare-new-version-2.0.0from
633-for-tab-bar-component-update-the-animation-of-the-selected-tab-indicator

Conversation

@AhmedAmineZr
Copy link
Copy Markdown
Member

@AhmedAmineZr AhmedAmineZr commented May 15, 2026 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

closes #625 #627

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • CHANGELOG.md files have been updated respecting keep a changelog rules and referencing the issue

@AhmedAmineZr AhmedAmineZr requested a review from nouha06 May 15, 2026 12:52
@AhmedAmineZr AhmedAmineZr self-assigned this May 15, 2026
@AhmedAmineZr AhmedAmineZr linked an issue May 15, 2026 that may be closed by this pull request
For tab bar component, update the animation of the selected tab indicator #633
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026 •
edited
Loading

📖 Documentation preview deployed!

🔗 https://flutter.unified-design-system.orange.com/prPreview/771/

github-actions Bot pushed a commit that referenced this pull request May 15, 2026
@actions-user
doc: deploy PR #771 preview
f98d6d1
@AhmedAmineZr AhmedAmineZr linked an issue May 16, 2026 that may be closed by this pull request
[A11Y][Bottom Bar][iOS] Overlap when zoom is activated #627
Open
1 task
github-actions Bot pushed a commit that referenced this pull request May 16, 2026
@actions-user
doc: deploy PR #771 preview
f4ec29e
@AhmedAmineZr AhmedAmineZr force-pushed the 633-for-tab-bar-component-update-the-animation-of-the-selected-tab-indicator branch from 221eb8b to 15aa544 Compare May 16, 2026 13:10
github-actions Bot pushed a commit that referenced this pull request May 16, 2026
@actions-user
doc: deploy PR #771 preview
5088496
@AhmedAmineZr AhmedAmineZr force-pushed the 633-for-tab-bar-component-update-the-animation-of-the-selected-tab-indicator branch from 15aa544 to 91e193f Compare May 16, 2026 13:40
github-actions Bot pushed a commit that referenced this pull request May 16, 2026
@actions-user
doc: deploy PR #771 preview
41f9cc3
@AhmedAmineZr AhmedAmineZr force-pushed the 633-for-tab-bar-component-update-the-animation-of-the-selected-tab-indicator branch from 91e193f to 7996128 Compare May 16, 2026 13:47
github-actions Bot pushed a commit that referenced this pull request May 16, 2026
@actions-user
doc: deploy PR #771 preview
23b5674
@AhmedAmineZr AhmedAmineZr force-pushed the 633-for-tab-bar-component-update-the-animation-of-the-selected-tab-indicator branch from 7996128 to 482998c Compare May 16, 2026 13:58
github-actions Bot pushed a commit that referenced this pull request May 16, 2026
@actions-user
doc: deploy PR #771 preview
8f7b664
@AhmedAmineZr AhmedAmineZr changed the base branch from develop to prepare-new-version-2.0.0 May 19, 2026 23:12
@AhmedAmineZr AhmedAmineZr changed the title chore:update Bottom Bar with animation indacator chore:update Bottom Bar with animation indicator May 19, 2026
nouha06
nouha06 reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nouha06 nouha06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the item with notification (dot or count) no accessibility hear to say there is a notification as mentioned in the ticket

With notification, Talkback should read informations in the following order "Label, 1 notification, Tab 2 of 3"

@AhmedAmineZr AhmedAmineZr force-pushed the 633-for-tab-bar-component-update-the-animation-of-the-selected-tab-indicator branch 7 times, most recently from 858de09 to c5cf6cd Compare May 21, 2026 11:49
@AhmedAmineZr
Merge branch 'prepare-new-version-2.0.0' into 633-for-tab-bar-compone…
26499cd 
…nt-update-the-animation-of-the-selected-tab-indicator

# Conflicts:
#	ouds_core/lib/components/navigation/ouds_navigation_bar_item.dart
@AhmedAmineZr AhmedAmineZr force-pushed the 633-for-tab-bar-component-update-the-animation-of-the-selected-tab-indicator branch from c712dff to 26499cd Compare May 21, 2026 12:15
@AhmedAmineZr AhmedAmineZr force-pushed the 633-for-tab-bar-component-update-the-animation-of-the-selected-tab-indicator branch from ca1ea87 to 726667d Compare May 22, 2026 14:06
@AhmedAmineZr
Merge branch 'prepare-new-version-2.0.0' into 633-for-tab-bar-compone…
be20d28 
…nt-update-the-animation-of-the-selected-tab-indicator

# Conflicts:
#	app/CHANGELOG.md
#	ouds_core/CHANGELOG.md
@AhmedAmineZr
chore: resolve a11y zoom and voiceOver
35d1eb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nouha06 nouha06 nouha06 left review comments

Assignees

@AhmedAmineZr AhmedAmineZr

Labels

👂 accessibility ⚛️ component 🧩 enhancement New feature or request 🧰 library

Projects

None yet

Milestone

No milestone

2 participants

@AhmedAmineZr @nouha06