Skip to content

Commit 31708ff

Browse files
committed
fix: vocalisation of "info" status for alert components (#1561) (#1619)
For alert message and inline alert components, manage the "info" status case to vocalize a prefix like "warning" and "negative" cases. Closes #1561 Reported-by: Pierre-Yves Ayoul <pierre-yves.ayoul@orange.com> Reviewed-by: Copilot <198982749+Copilot@users.noreply.github.com> Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
1 parent de07621 commit 31708ff

4 files changed

Lines changed: 30 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3434

3535
### Fixed
3636

37-
- Icon assets for unordered list item not displayed (Orange-OpenSource/ouds-ios#1615)
37+
- For `alert` components, add default vocalisation on "info" status (Orange-OpenSource/ouds-ios#1561)
38+
- Icon assets for unordered `bullet list` item not displayed (Orange-OpenSource/ouds-ios#1615)
3839

3940
### Removed
4041

OUDS/Core/Components/Sources/Dialogs/Alert/Internal/AlertMessage/AlertMessageContent.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,8 @@ struct AlertMessageContent: View {
8888
"core_alertMessage_warning_a11y".localized() + ","
8989
case .negative:
9090
"core_alertMessage_negative_a11y".localized() + ","
91+
case .info:
92+
"core_alertMessage_info_a11y".localized() + ","
9193
default:
9294
""
9395
}

OUDS/Core/Components/Sources/Dialogs/Alert/Internal/InlineAlert/InlineAlertLabel.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ struct InlineAlertLabel: View {
5555
"core_alertMessage_warning_a11y".localized() + ","
5656
case .negative:
5757
"core_alertMessage_negative_a11y".localized() + ","
58+
case .info:
59+
"core_alertMessage_info_a11y".localized() + ","
5860
default:
5961
""
6062
}

OUDS/Core/Components/Sources/_/Resources/Localizable.xcstrings

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,30 @@
2828
}
2929
}
3030
},
31+
"core_alertMessage_info_a11y" : {
32+
"comment" : "Component - Alerts",
33+
"extractionState" : "manual",
34+
"localizations" : {
35+
"ar" : {
36+
"stringUnit" : {
37+
"state" : "translated",
38+
"value" : "معلومة"
39+
}
40+
},
41+
"en" : {
42+
"stringUnit" : {
43+
"state" : "translated",
44+
"value" : "Information"
45+
}
46+
},
47+
"fr" : {
48+
"stringUnit" : {
49+
"state" : "translated",
50+
"value" : "Information"
51+
}
52+
}
53+
}
54+
},
3155
"core_alertMessage_negative_a11y" : {
3256
"comment" : "Component - Alerts",
3357
"extractionState" : "manual",

0 commit comments

Comments
 (0)