[#1577] Add missing localized string for back button of toolbar top component#1620
Merged
pylapp merged 2 commits intoJul 15, 2026
Conversation
3 tasks
There was a problem hiding this comment.
Pull request overview
Fixes an accessibility regression in toolbar top where VoiceOver could announce the raw localization key by adding the missing core_common_back entry to the Components localization resources.
Changes:
- Added
core_common_backtranslations (ar/en/fr) toLocalizable.xcstrings. - Kept
OUDSToolBarItem.NavigationType.backdefault accessibility label tied tocore_common_back.localized(). - Documented the fix in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| OUDS/Core/Components/Sources/Navigations/ToolBar/OUDSToolBarItem.swift | Ensures the back button’s default a11y label is based on the core_common_back localization key and updates related inline documentation. |
| OUDS/Core/Components/Sources/_/Resources/Localizable.xcstrings | Adds the missing core_common_back localized string so the key resolves to user-facing text. |
| CHANGELOG.md | Records the accessibility/localization fix for the upcoming release notes. |
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
pylapp
force-pushed
the
1577-for-toolbar-top-component-the-back-button-is-not-well-vocalized
branch
from
July 15, 2026 10:56
912f1a9 to
6261ce1
Compare
pylapp
deleted the
1577-for-toolbar-top-component-the-back-button-is-not-well-vocalized
branch
July 15, 2026 10:58
pylapp
added a commit
that referenced
this pull request
Jul 15, 2026
…#1577) (#1620) Add missing localized string "core_common_back". Fix also some typo in documentation. Closes #1577 Reported-by: Jean-Luc Chevalier <jl.chevalier@orange.com> Reviewed-by: Copilot <198982749+Copilot@users.noreply.github.com> Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
#1577
Description
Add missing wording key for default a11Y label of toolbar top back button
Motivation & Context
Fix a11y issue where Voice Over vocalized wording key
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)